Skip to content

Fix certifier test permissions #13473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bneradt wants to merge 1 commit into
base: master
Choose a base branch
from
+18 −8
Open

Fix certifier test permissions #13473

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 18 additions & 8 deletions tests/gold_tests/pluginTest/certifier/certifier.test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,20 @@
Test.SkipUnless(Condition.PluginExists('certifier.so'))


def prepare_certifier_storage(source_path: str, destination_path: str) -> None:
"""Copy the certifier files and make its mutable state writable by ATS."""
store_path = os.path.join(destination_path, 'store')
serial_path = os.path.join(destination_path, 'ca-serial.txt')

def set_permissions() -> None:
os.chmod(serial_path, 0o666)
os.chmod(store_path, 0o777)

Setup.Copy(source_path, destination_path)
Setup.MakeDir(store_path)
Setup.Lambda(func_setup=set_permissions, description="Make certifier state writable by ATS")


class DynamicCertTest:
httpsReplayFile = "replays/https.replay.yaml"
certPathSrc = os.path.join(Test.TestDirectory, "certs")
Expand All @@ -44,8 +58,7 @@ def setupTS(self):
self.ts.addDefaultSSLFiles()
# copy over the cert store in which the certs will be generated/stored
self.certPathDest = os.path.join(self.ts.Variables.CONFIGDIR, "certifier-certs")
Setup.Copy(self.certPathSrc, self.certPathDest)
Setup.MakeDir(os.path.join(self.certPathDest, 'store'))
prepare_certifier_storage(self.certPathSrc, self.certPathDest)
self.ts.Disk.records_config.update(
{
"proxy.config.diags.debug.enabled": 1,
Expand Down Expand Up @@ -125,8 +138,7 @@ def setupTS(self):
self.ts.addDefaultSSLFiles()
# copy over the cert store in which the certs will be generated/stored
self.certPathDest = os.path.join(self.ts.Variables.CONFIGDIR, "certifier-certs")
Setup.Copy(self.certPathSrc, self.certPathDest)
Setup.MakeDir(os.path.join(self.certPathDest, 'store'))
prepare_certifier_storage(self.certPathSrc, self.certPathDest)
self.ts.Disk.records_config.update(
{
"proxy.config.diags.debug.enabled": 1,
Expand Down Expand Up @@ -182,8 +194,7 @@ def setupTS(self):
self.ts = Test.MakeATSProcess("ts3", enable_tls=True)
self.ts.addDefaultSSLFiles()
self.certPathDest = os.path.join(self.ts.Variables.CONFIGDIR, "certifier-certs")
Setup.Copy(self.certPathSrc, self.certPathDest)
Setup.MakeDir(os.path.join(self.certPathDest, 'store'))
prepare_certifier_storage(self.certPathSrc, self.certPathDest)
self.ts.Disk.records_config.update(
{
"proxy.config.diags.debug.enabled": 1,
Expand Down Expand Up @@ -245,8 +256,7 @@ def setupTS(self):
self.ts = Test.MakeATSProcess("ts4", enable_tls=True)
self.ts.addDefaultSSLFiles()
self.certPathDest = os.path.join(self.ts.Variables.CONFIGDIR, "certifier-certs")
Setup.Copy(self.certPathSrc, self.certPathDest)
Setup.MakeDir(os.path.join(self.certPathDest, 'store'))
prepare_certifier_storage(self.certPathSrc, self.certPathDest)
self.ts.Disk.records_config.update(
{
"proxy.config.diags.debug.enabled": 1,
Expand Down