This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Adding a Traffic Ops client method to login with a certificate#7645
Merged
zrhoffman merged 9 commits intoapache:masterfrom Jul 17, 2023
Merged
Adding a Traffic Ops client method to login with a certificate#7645zrhoffman merged 9 commits intoapache:masterfrom
zrhoffman merged 9 commits intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7645 +/- ##
============================================
- Coverage 30.12% 30.12% -0.01%
Complexity 98 98
============================================
Files 794 794
Lines 84077 84086 +9
Branches 907 907
============================================
+ Hits 25332 25334 +2
- Misses 56615 56620 +5
- Partials 2130 2132 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ocket8888
added
new feature
ocket8888
reviewed
Jul 13, 2023
zrhoffman
approved these changes
Jul 17, 2023
Member
zrhoffman
left a comment
zrhoffman
left a comment
There was a problem hiding this comment.
Looks good! Just 1 comment about the cert expirations, but they can be addressed in a follow-up PR :)
| @@ -0,0 +1,34 @@ | |||
| -----BEGIN CERTIFICATE----- | |||
Member
There was a problem hiding this comment.
These cert files expire on July 13, 2024, which means they would need to be updated in a year. Instead, how about making them expire July 13, 2124?
jagan-parthiban
pushed a commit
to jagan-parthiban/trafficcontrol
that referenced
this pull request
Jul 27, 2023
…e#7645) * Adding a Traffic Ops client method to login with a certificate * adding changelog, godocs * adding . in changelog * try to fix gha * add sudo * wip * adding debug * adding insecure skip verify option * remove debug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is not related to any issue. It adds a Traffic Ops client method to be able to login with certs.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Make sure all the tests pass.
Manual testing:
Follow the steps in #7392
If this is a bugfix, which Traffic Control versions contained the bug?
PR submission checklist