This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Fix docs for DS retries#7039
Open
rob05c wants to merge 1 commit intoapache:masterfrom
Open
Conversation
rob05c
added
documentation
rob05c
force-pushed
the
add-t3c-simple-retries
branch
from
4f77f0f to
df3d745
Compare
rob05c
force-pushed
the
add-t3c-simple-retries
branch
2 times, most recently
from
894e327 to
5ce438f
Compare
* Allow lock updates on some server params * Add CHANGELOG and dont update when non-allowed fields are present. * Sort changelog * Fix issues * Code review and add to v5 tests
rob05c
force-pushed
the
add-t3c-simple-retries
branch
from
5ce438f to
87435c0
Compare
ocket8888
reviewed
Sep 21, 2022
| // are assumed to be present). | ||
| // doTail calls t3c-tail and will run a tail on the log file provided with string for a regex to | ||
| // match on default is .* endMatch will make t3c-tail exit when a pattern is matched otherwise | ||
| // a timeout in a given number of seconds will occur. |
Contributor
There was a problem hiding this comment.
This is removing quite a bit of relevant information, like the fact that this prints to stdout, and also falsely claims some sort of default 'logMatch' value.
Everything after the first paragraph is arguably extraneous, but as-is this edit makes the behavior of doTail misleading at best, IMO.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds and clarifies docs for simple and unavailable retry parameters. Also fixes some related code comments.
Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Generate docs, observe they match code and ATS behavior.
If this is a bugfix, which Traffic Control versions contained the bug?
Not a bug fix.
PR submission checklist
[x] This PR has testsno tests, no code change[x] This PR has a CHANGELOG.md entryno changelog, docs fix is too trivial to clutter the changelog