[Issue-1617] - Traffic Ops Keeps track of configuration differences between database and Traffic Servers#1993
[Issue-1617] - Traffic Ops Keeps track of configuration differences between database and Traffic Servers#1993KevinMackenzie wants to merge 4 commits intoapache:masterfrom
Conversation
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
dangogh
left a comment
dangogh
left a comment
There was a problem hiding this comment.
pointed out a few things based on changes that we've made recently in the go implementation. Good start, though..
There was a problem hiding this comment.
any reason this is not just id?
There was a problem hiding this comment.
no functional reason
There was a problem hiding this comment.
every other table uses id -- should stick with that...
There was a problem hiding this comment.
these PrivLevel consts should go away -- we're using the auth.PrivLevel... consts to control individual routes in routes.go
There was a problem hiding this comment.
is this Response struct used in more than one place? If not, should probably just define it where it's used rather than making it exported.
There was a problem hiding this comment.
shouldn't this also include domainName to make sure it's unique?
There was a problem hiding this comment.
Yea, I didn't know whether host_names were unique or not. Should the host_name and domain_name be sufficient?
There was a problem hiding this comment.
should probably just use QueryRow() which will return a single response
|
ok to test |
|
Refer to this link for build results (access rights to CI server needed): |
KevinMackenzie
force-pushed
the
issue-1617
branch
from
c14198b to
25fa720
Compare
|
Refer to this link for build results (access rights to CI server needed): |
|
Can one of the admins verify this patch? |
|
@KevinMackenzie are you still interested in getting this merged? |
|
Yea, I can update the code to fit the current structure and guidelines if the feature still makes sense for the current state of the project (this PR is from when trafficcontrol still had incubator status). |
mitchell852
added
Traffic Ops
mitchell852
added
cache-config
5 participants
PR for feature #1617