Skip to content

chore(pyamber): silence pkg_resources deprecation warning from fs import #6880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aglinxinyuan wants to merge 1 commit into
base: main
Choose a base branch
from
+17 −1
Open

chore(pyamber): silence pkg_resources deprecation warning from fs import #6880

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion amber/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,4 +42,9 @@ testpaths = ["src/test/python"]
addopts = "--import-mode=importlib"
markers = [
"integration: end-to-end test routed to the amber-integration CI job",
]
]
# `fs` pulls in pkg_resources at import time (#4199); the same filter lives in
# texera_run_python_worker.py for spawned workers.
filterwarnings = [
"ignore:pkg_resources is deprecated as an API.*:UserWarning",
]
11 changes: 11 additions & 0 deletions amber/src/main/python/texera_run_python_worker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,19 @@
import base64
import json
import sys
import warnings
from loguru import logger

# `fs` (imported transitively by the core import below) pulls in pkg_resources
# at import time (#4199), which emits this deprecation warning on stderr in
# every spawned worker. It is not actionable on our side, so filter it before
# the import chain runs. Mirrored for pytest in amber/pyproject.toml.
warnings.filterwarnings(

@mengw15 mengw15 Jul 25, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Narrow, well-scoped filter — no objection to silencing this. One thing worth surfacing: this warning was also the only recurring signal that we're pinned on an EOL fs (2.4.16 is the last release) and holding setuptools below the pkg_resources removal (#4199). Once it's quiet, that debt only lives in this comment. There's no open tracking issue for migrating off PyFilesystem2 / handling the eventual pkg_resources removal — worth opening one and linking it here so the debt stays visible after the reminder is gone. Not blocking.

"ignore",
message="pkg_resources is deprecated as an API.*",
category=UserWarning,
)

try:
from core.python_worker import PythonWorker
from core.storage.storage_config import StorageConfig
Expand Down
Loading