refactor(frontend): extract dataset settings into Settings tab - #6493
Queued
rbelavadi wants to merge 11 commits into
Queued
refactor(frontend): extract dataset settings into Settings tab#6493rbelavadi wants to merge 11 commits into
rbelavadi wants to merge 11 commits into
Conversation
Contributor
Automated Reviewer SuggestionsBased on the
|
Contributor
Author
|
/request-review @xuang7 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6493 +/- ##
============================================
- Coverage 78.96% 78.87% -0.09%
+ Complexity 3798 3765 -33
============================================
Files 1161 1161
Lines 46084 46140 +56
Branches 5110 5115 +5
============================================
+ Hits 36388 36391 +3
- Misses 8076 8135 +59
+ Partials 1620 1614 -6
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
xuang7
requested changes
Jul 18, 2026
xuang7
left a comment
Contributor
There was a problem hiding this comment.
Generally LGTM! I left a few comments. Since we now have a new rename method, could you please update this to reuse the same logic here?
Ma77Ball
reviewed
Jul 19, 2026
…ct-dataset-settings-tab
xuang7
approved these changes
Jul 23, 2026
xuang7
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Please resolve the conflicts and update the PR description.
Signed-off-by: Ranjani Veena Belavadi <161239545+rbelavadi@users.noreply.github.com>
…ct-dataset-settings-tab
…github.com/rbelavadi/texera into refactor/6395-extract-dataset-settings-tab
xuang7
enabled auto-merge
July 27, 2026 20:10
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
Extracted the dataset settings/admin functionality on the dataset detail page into a dedicated Settings tab, alongside existing content (now under a Data Card tab). Part of the parent tab-based layout refactor (#6394).
Visibility toggle, downloadable toggle, and description editor moved from the header's gear-icon popover into the new Settings tab. The gear icon and popover are removed.
Added dataset rename (input + Save), calling the existing
DatasetService.updateDatasetName()and reusing the name-sanitization logic already used in the dataset version creator.Added dataset delete, calling the existing
DatasetService.deleteDatasets()with the samenz-popconfirmconfirmation pattern used on the Datasets list page; redirects to the list on success.Before: settings were scattered, visibility/downloadable behind a gear icon, description editable only in the header, rename/delete only reachable from the Datasets list page.

After: all dataset settings are consolidated in one Settings tab on the detail page itself.

Any related issues, documentation, discussions?
Closes #6395
How was this PR tested?
Added 7 unit tests to
dataset-detail.component.spec.tscovering the two new methods (onSaveDatasetName,onDeleteDataset): name sanitization, success/error paths, and navigation on delete. The relocated toggles/description editor already had existing test coverage prior to this PR, so no new tests were needed there. 66/66 tests passing (59 pre-existing, 7 new).Also manually tested on UI, since the relocated functionality itself is unchanged behavior:
Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Claude Opus 4.8)