feat: Adding a connection pool to reduce the time spent opening connection to Postgres#4851
Open
Ma77Ball wants to merge 6 commits intoapache:mainfrom
Open
feat: Adding a connection pool to reduce the time spent opening connection to Postgres#4851Ma77Ball wants to merge 6 commits intoapache:mainfrom
Ma77Ball wants to merge 6 commits intoapache:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4851 +/- ##
=========================================
Coverage 42.16% 42.17%
Complexity 2180 2180
=========================================
Files 980 980
Lines 36305 36297 -8
Branches 3783 3783
=========================================
Hits 15309 15309
+ Misses 20068 20060 -8
Partials 928 928
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Yicong-Huang
requested changes
May 3, 2026
Contributor
Yicong-Huang
left a comment
There was a problem hiding this comment.
Looks good to me! Left inline comments
Contributor
|
please also change the title. this is not a refactor. we are adding a new feature. |
Yicong-Huang
reviewed
May 5, 2026
|
|
||
| libraryDependencies ++= Seq( | ||
| "org.postgresql" % "postgresql" % "42.7.4", | ||
| "com.zaxxer" % "HikariCP" % "5.1.0" |
Contributor
There was a problem hiding this comment.
the latest version is HikariCP-7.0.2, any particular reason to stay on v5.1.0?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
This PR adds a HikariCP connection pool to SqlServer.scala so that jOOQ queries borrow pre-authenticated connections from a pool instead of opening a new TCP connection and performing SCRAM-SHA-256 authentication on every database call.
What changed in SqlServer.scala:
Any related issues, documentation, discussions?
closes: #4852
How was this PR tested?
Was this PR authored or co-authored using generative AI tooling?
Co-authored with Claude opus 4.6 (Anthropic) in compliance with ASF