feat(frontend): add inert UDF UiParameter property editor support#4832
Draft
carloea2 wants to merge 2 commits intoapache:mainfrom
Draft
feat(frontend): add inert UDF UiParameter property editor support#4832carloea2 wants to merge 2 commits intoapache:mainfrom
carloea2 wants to merge 2 commits intoapache:mainfrom
Conversation
Contributor
Author
|
@kunwp1 please confirm if this layout is ok for you to review. Then I can test it locally and request your review once it is ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
This is PR 1 of the UiParameter split stack.
This PR adds the frontend and schema surface needed to load and display
uiParametersin Python UDF operator properties, without changing workflow execution behavior.It includes:
uiParametersproperty.UiUDFParameterschema model.ui-udf-parameterseditor.uiParametersrenders as a dedicated Parameters section.Execution remains unchanged: descriptors still execute the original Python code.
sequenceDiagram autonumber participant JSON as Workflow JSON participant Desc as Scala UDF Descriptor participant Props as Operator Properties participant Formly as Formly Property Editor participant UI as UiUdfParametersComponent participant Exec as Existing Execution Path JSON->>Desc: Load uiParameters property Desc->>Props: Preserve uiParameters metadata Props->>Formly: Render operator schema Formly->>UI: Use ui-udf-parameters editor UI-->>Formly: Edit values only Formly->>Props: Save uiParameters Props->>Exec: Execute unchanged code path