Skip to content

fix(ui): update computing unit status on /compute tab every second#4612

Open
gracecluvohio wants to merge 4 commits intoapache:mainfrom
gracecluvohio:grace/fix-computing-unit-status
Open

fix(ui): update computing unit status on /compute tab every second#4612
gracecluvohio wants to merge 4 commits intoapache:mainfrom
gracecluvohio:grace/fix-computing-unit-status

Conversation

@gracecluvohio
Copy link
Copy Markdown
Contributor

What changes were proposed in this PR?

Refresh computing unit status on the \compute tab once per second.

Demo:

Screen.Recording.2026-05-01.at.9.16.23.AM.mov

Any related issues, documentation, discussions?

Closes #4611

How was this PR tested?

Locally

Was this PR authored or co-authored using generative AI tooling?

No

@github-actions github-actions Bot added the frontend Changes related to the frontend GUI label May 1, 2026
@chenlica chenlica requested a review from aicam May 2, 2026 00:25
@chenlica
Copy link
Copy Markdown
Contributor

chenlica commented May 2, 2026

@aicam Please review it.

Copy link
Copy Markdown
Contributor

@aicam aicam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aicam aicam enabled auto-merge (squash) May 2, 2026 18:54
Comment on lines +150 to +154
interval(1000)
.pipe(untilDestroyed(this))
.subscribe(() => {
this.computingUnitStatusService.refreshComputingUnitList();
});
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we make it event driven, instead of every second?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be a better user experience to make it every second, so that the status is as fresh as possible.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can deliver the same user experience. I am talking about implementation. can we make it event driven? for example, when some status changed, push an event to frontend to update the computing unit list.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless I'm mistaken, I don't think the existing services we have expose "messages" or events sent from the backend, they just expose functionality for refreshing all of the computing units. I think a timer based refreshing is most consistent with the functions we currently have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend Changes related to the frontend GUI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compute status does not update in compute tab until you refresh the page

4 participants