Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
JSONObject/JSONArray's toString()andtoCompactString()are slower than necessary due to synchronization overhead and per-String allocation in the print path.My sandbox implementation at https://github.com/benweidig/tapestry-json-improvements (non-breaking, verified byte-for-byte against current output) shows a ~4-6x speedup across payload sizes and both compact/pretty formatting, with no public API changes.
Changes
JSONStringerand inlined its escaping loop directly intoJSONObject. There is some code duplication, but it keeps the call sites monomorphic and should allow for better C2 optimization in the JVM.String.formatcallsCharArrayWriter/PrintWriterand build directlty intoStringBuilderResults
Graphs: JMH Visalizer
End-to-end cost:
JSONSerializationBenchmark(toString()/toCompactString())Isolated escaping cost:
StringQuotingBenchmark(JSONObject.quote(String))