Skip to content

[BWARE] Track more compressed-friendly ops in FederatedWorkloadAnalyzer#2481

Open
Baunsgaard wants to merge 1 commit into
apache:mainfrom
Baunsgaard:split/federatedAnalyzer
Open

[BWARE] Track more compressed-friendly ops in FederatedWorkloadAnalyzer#2481
Baunsgaard wants to merge 1 commit into
apache:mainfrom
Baunsgaard:split/federatedAnalyzer

Conversation

@Baunsgaard
Copy link
Copy Markdown
Contributor

Extends the federated workload counter so that compression decisions account for additional instruction shapes beyond AggregateBinary.

  • Pass the right-hand column count to incOverlappingDecompressions so the cost model reflects the actual decompression size rather than counting a single column
  • Count MMChainCPInstruction as one LMM and one RMM contribution per invocation
  • Count AggregateUnaryCPInstruction: when reducing columns with a sum/mean operator, treat it as a dict-op (compression-friendly); otherwise count it as a decompression
  • Minor formatting cleanup in compressRun

Extends the federated workload counter so that compression decisions
account for additional instruction shapes beyond AggregateBinary.

- Pass the right-hand column count to incOverlappingDecompressions
  so the cost model reflects the actual decompression size rather
  than counting a single column
- Count MMChainCPInstruction as one LMM and one RMM contribution per
  invocation
- Count AggregateUnaryCPInstruction: when reducing columns with a
  sum/mean operator, treat it as a dict-op (compression-friendly);
  otherwise count it as a decompression
- Minor formatting cleanup in compressRun
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 8, 2026

Codecov Report

❌ Patch coverage is 4.76190% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.37%. Comparing base (88c26e2) to head (fdfc718).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...olprogram/federated/FederatedWorkloadAnalyzer.java 4.76% 20 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2481      +/-   ##
============================================
- Coverage     71.37%   71.37%   -0.01%     
- Complexity    48749    48753       +4     
============================================
  Files          1571     1571              
  Lines        188912   188932      +20     
  Branches      37067    37072       +5     
============================================
+ Hits         134845   134855      +10     
- Misses        43601    43625      +24     
+ Partials      10466    10452      -14     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

1 participant