Skip to content

improve release_notes.py: filter noise labels and guard against stale GitHub index #8903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
reiabreu wants to merge 2 commits into from
Closed

improve release_notes.py: filter noise labels and guard against stale GitHub index #8903

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d9735f
[maven-release-plugin] prepare release v3.0.0
reiabreu Jul 18, 2026
cbc5c43
improve release_notes.py: ignore github_actions/skip-changelog labels…
reiabreu Jul 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/update-license-files.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,4 +79,6 @@ jobs:
- `LICENSE-binary` (binary dependencies section)

Please review the changes and merge if correct.
labels: dependencies
labels: |
dependencies
skip-changelog
27 changes: 26 additions & 1 deletion dev-tools/release_notes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,13 +102,38 @@ def issue_link(issue):
print("No issues found for the specified milestone.", file=sys.stderr)
sys.exit(1)

unresolved_issues = [issue for issue in issues if issue["state"] != "closed"]
def is_truly_open(issue):
if issue["state"] == "closed":
return False
# Re-fetch the issue directly to guard against stale index returning issues
# whose milestone was already removed (known GitHub API inconsistency)
url = f"{GITHUB_API_BASE_URL}/repos/{owner}/{repo}/issues/{issue['number']}"
r = requests.get(url, headers=headers)
if r.status_code != 200:
return True # conservative: treat as unresolved if we can't verify
return r.json().get("milestone") is not None

unresolved_issues = [issue for issue in issues if is_truly_open(issue)]
if unresolved_issues:
print("The release is not completed since unresolved issues were found:", file=sys.stderr)
for issue in unresolved_issues:
print(f"Unresolved issue: {issue['number']:5d} {issue['state']:10s} {issue_link(issue)}", file=sys.stderr)
sys.exit(1)

IGNORED_LABELS = {"github_actions", "skip-changelog"}

ignored = [
issue for issue in issues
if any(l["name"] in IGNORED_LABELS for l in issue["labels"])
]
if ignored:
print(f"Ignoring {len(ignored)} issue(s) with excluded labels ({', '.join(IGNORED_LABELS)}):", file=sys.stderr)
for issue in ignored:
matched = [l["name"] for l in issue["labels"] if l["name"] in IGNORED_LABELS]
print(f" #{issue['number']} [{', '.join(matched)}] - {issue['title']}", file=sys.stderr)

issues = [issue for issue in issues if issue not in ignored]

# Group issues by labels, assigning each issue to only its first label
# to avoid duplicates when an issue has multiple labels
issues_by_label = {}
Expand Down
2 changes: 1 addition & 1 deletion examples/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
<parent>
<artifactId>storm</artifactId>
<groupId>org.apache.storm</groupId>
<version>3.0.0-SNAPSHOT</version>
<version>3.0.0</version>
<relativePath>../pom.xml</relativePath>
</parent>

Expand Down
2 changes: 1 addition & 1 deletion examples/storm-hdfs-examples/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
<parent>
<artifactId>storm-examples</artifactId>
<groupId>org.apache.storm</groupId>
<version>3.0.0-SNAPSHOT</version>
<version>3.0.0</version>
<relativePath>../pom.xml</relativePath>
</parent>

Expand Down
2 changes: 1 addition & 1 deletion examples/storm-jdbc-examples/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
<parent>
<artifactId>storm-examples</artifactId>
<groupId>org.apache.storm</groupId>
<version>3.0.0-SNAPSHOT</version>
<version>3.0.0</version>
<relativePath>../pom.xml</relativePath>
</parent>

Expand Down
2 changes: 1 addition & 1 deletion examples/storm-jms-examples/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
<parent>
<artifactId>storm-examples</artifactId>
<groupId>org.apache.storm</groupId>
<version>3.0.0-SNAPSHOT</version>
<version>3.0.0</version>
<relativePath>../pom.xml</relativePath>
</parent>

Expand Down
2 changes: 1 addition & 1 deletion examples/storm-kafka-client-examples/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
<parent>
<artifactId>storm-examples</artifactId>
<groupId>org.apache.storm</groupId>
<version>3.0.0-SNAPSHOT</version>
<version>3.0.0</version>
<relativePath>../pom.xml</relativePath>
</parent>

Expand Down
2 changes: 1 addition & 1 deletion examples/storm-loadgen/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
<parent>
<artifactId>storm-examples</artifactId>
<groupId>org.apache.storm</groupId>
<version>3.0.0-SNAPSHOT</version>
<version>3.0.0</version>
<relativePath>../pom.xml</relativePath>
</parent>
<artifactId>storm-loadgen</artifactId>
Expand Down
2 changes: 1 addition & 1 deletion examples/storm-perf/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
<parent>
<artifactId>storm-examples</artifactId>
<groupId>org.apache.storm</groupId>
<version>3.0.0-SNAPSHOT</version>
<version>3.0.0</version>
<relativePath>../pom.xml</relativePath>
</parent>

Expand Down
2 changes: 1 addition & 1 deletion examples/storm-redis-examples/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
<parent>
<artifactId>storm-examples</artifactId>
<groupId>org.apache.storm</groupId>
<version>3.0.0-SNAPSHOT</version>
<version>3.0.0</version>
<relativePath>../pom.xml</relativePath>
</parent>

Expand Down
2 changes: 1 addition & 1 deletion examples/storm-starter/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
<parent>
<artifactId>storm-examples</artifactId>
<groupId>org.apache.storm</groupId>
<version>3.0.0-SNAPSHOT</version>
<version>3.0.0</version>
<relativePath>../pom.xml</relativePath>
</parent>

Expand Down
2 changes: 1 addition & 1 deletion external/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
<parent>
<artifactId>storm</artifactId>
<groupId>org.apache.storm</groupId>
<version>3.0.0-SNAPSHOT</version>
<version>3.0.0</version>
<relativePath>../pom.xml</relativePath>
</parent>

Expand Down
2 changes: 1 addition & 1 deletion external/storm-autocreds/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
<parent>
<artifactId>storm-external</artifactId>
<groupId>org.apache.storm</groupId>
<version>3.0.0-SNAPSHOT</version>
<version>3.0.0</version>
<relativePath>../pom.xml</relativePath>
</parent>
<modelVersion>4.0.0</modelVersion>
Expand Down
2 changes: 1 addition & 1 deletion external/storm-blobstore-migration/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ limitations under the License.
<parent>
<artifactId>storm-external</artifactId>
<groupId>org.apache.storm</groupId>
<version>3.0.0-SNAPSHOT</version>
<version>3.0.0</version>
<relativePath>../pom.xml</relativePath>
</parent>

Expand Down
2 changes: 1 addition & 1 deletion external/storm-hdfs-blobstore/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
<parent>
<artifactId>storm-external</artifactId>
<groupId>org.apache.storm</groupId>
<version>3.0.0-SNAPSHOT</version>
<version>3.0.0</version>
<relativePath>../pom.xml</relativePath>
</parent>

Expand Down
2 changes: 1 addition & 1 deletion external/storm-hdfs-oci/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
<parent>
<artifactId>storm-external</artifactId>
<groupId>org.apache.storm</groupId>
<version>3.0.0-SNAPSHOT</version>
<version>3.0.0</version>
<relativePath>../pom.xml</relativePath>
</parent>
<modelVersion>4.0.0</modelVersion>
Expand Down
2 changes: 1 addition & 1 deletion external/storm-hdfs/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
<parent>
<artifactId>storm-external</artifactId>
<groupId>org.apache.storm</groupId>
<version>3.0.0-SNAPSHOT</version>
<version>3.0.0</version>
<relativePath>../pom.xml</relativePath>
</parent>

Expand Down
2 changes: 1 addition & 1 deletion external/storm-jdbc/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
<parent>
<artifactId>storm-external</artifactId>
<groupId>org.apache.storm</groupId>
<version>3.0.0-SNAPSHOT</version>
<version>3.0.0</version>
<relativePath>../pom.xml</relativePath>
</parent>

Expand Down
2 changes: 1 addition & 1 deletion external/storm-jms/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
<parent>
<artifactId>storm-external</artifactId>
<groupId>org.apache.storm</groupId>
<version>3.0.0-SNAPSHOT</version>
<version>3.0.0</version>
<relativePath>../pom.xml</relativePath>
</parent>

Expand Down
2 changes: 1 addition & 1 deletion external/storm-kafka-client/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
<parent>
<artifactId>storm-external</artifactId>
<groupId>org.apache.storm</groupId>
<version>3.0.0-SNAPSHOT</version>
<version>3.0.0</version>
<relativePath>../pom.xml</relativePath>
</parent>

Expand Down
2 changes: 1 addition & 1 deletion external/storm-kafka-migration/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
<parent>
<artifactId>storm-external</artifactId>
<groupId>org.apache.storm</groupId>
<version>3.0.0-SNAPSHOT</version>
<version>3.0.0</version>
<relativePath>../pom.xml</relativePath>
</parent>

Expand Down
2 changes: 1 addition & 1 deletion external/storm-kafka-monitor/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
<parent>
<artifactId>storm-external</artifactId>
<groupId>org.apache.storm</groupId>
<version>3.0.0-SNAPSHOT</version>
<version>3.0.0</version>
<relativePath>../pom.xml</relativePath>
</parent>
<modelVersion>4.0.0</modelVersion>
Expand Down
2 changes: 1 addition & 1 deletion external/storm-metrics-prometheus/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
<parent>
<artifactId>storm-external</artifactId>
<groupId>org.apache.storm</groupId>
<version>3.0.0-SNAPSHOT</version>
<version>3.0.0</version>
<relativePath>../pom.xml</relativePath>
</parent>

Expand Down
2 changes: 1 addition & 1 deletion external/storm-metrics/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
<parent>
<artifactId>storm-external</artifactId>
<groupId>org.apache.storm</groupId>
<version>3.0.0-SNAPSHOT</version>
<version>3.0.0</version>
<relativePath>../pom.xml</relativePath>
</parent>

Expand Down
2 changes: 1 addition & 1 deletion external/storm-redis/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
<parent>
<artifactId>storm-external</artifactId>
<groupId>org.apache.storm</groupId>
<version>3.0.0-SNAPSHOT</version>
<version>3.0.0</version>
<relativePath>../pom.xml</relativePath>
</parent>

Expand Down
2 changes: 1 addition & 1 deletion flux/flux-core/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
<parent>
<groupId>org.apache.storm</groupId>
<artifactId>flux</artifactId>
<version>3.0.0-SNAPSHOT</version>
<version>3.0.0</version>
<relativePath>../pom.xml</relativePath>
</parent>

Expand Down
2 changes: 1 addition & 1 deletion flux/flux-examples/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
<parent>
<groupId>org.apache.storm</groupId>
<artifactId>flux</artifactId>
<version>3.0.0-SNAPSHOT</version>
<version>3.0.0</version>
<relativePath>../pom.xml</relativePath>
</parent>

Expand Down
2 changes: 1 addition & 1 deletion flux/flux-wrappers/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
<parent>
<groupId>org.apache.storm</groupId>
<artifactId>flux</artifactId>
<version>3.0.0-SNAPSHOT</version>
<version>3.0.0</version>
<relativePath>../pom.xml</relativePath>
</parent>

Expand Down
2 changes: 1 addition & 1 deletion flux/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
<parent>
<artifactId>storm</artifactId>
<groupId>org.apache.storm</groupId>
<version>3.0.0-SNAPSHOT</version>
<version>3.0.0</version>
<relativePath>../pom.xml</relativePath>
</parent>

Expand Down
2 changes: 1 addition & 1 deletion integration-test/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
<parent>
<artifactId>storm</artifactId>
<groupId>org.apache.storm</groupId>
<version>3.0.0-SNAPSHOT</version>
<version>3.0.0</version>
<relativePath>../pom.xml</relativePath>
</parent>

Expand Down
4 changes: 2 additions & 2 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@

<groupId>org.apache.storm</groupId>
<artifactId>storm</artifactId>
<version>3.0.0-SNAPSHOT</version>
<version>3.0.0</version>
<packaging>pom</packaging>
<name>Storm</name>
<description>Distributed and fault-tolerant realtime computation</description>
Expand Down Expand Up @@ -59,7 +59,7 @@
<connection>git@github.com:apache/storm.git</connection>
<developerConnection>scm:git:https://gitbox.apache.org/repos/asf/storm.git</developerConnection>
<url>https://github.com/apache/storm</url>
<tag>v2.8.7</tag>
<tag>v3.0.0</tag>
</scm>

<issueManagement>
Expand Down
2 changes: 1 addition & 1 deletion storm-checkstyle/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
<parent>
<artifactId>storm</artifactId>
<groupId>org.apache.storm</groupId>
<version>3.0.0-SNAPSHOT</version>
<version>3.0.0</version>
<relativePath>../pom.xml</relativePath>
</parent>
<modelVersion>4.0.0</modelVersion>
Expand Down
2 changes: 1 addition & 1 deletion storm-client/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
<parent>
<artifactId>storm</artifactId>
<groupId>org.apache.storm</groupId>
<version>3.0.0-SNAPSHOT</version>
<version>3.0.0</version>
<relativePath>../pom.xml</relativePath>
</parent>

Expand Down
2 changes: 1 addition & 1 deletion storm-core/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
<parent>
<artifactId>storm</artifactId>
<groupId>org.apache.storm</groupId>
<version>3.0.0-SNAPSHOT</version>
<version>3.0.0</version>
<relativePath>../pom.xml</relativePath>
</parent>

Expand Down
2 changes: 1 addition & 1 deletion storm-dist/binary/final-package/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
<parent>
<artifactId>apache-storm-bin</artifactId>
<groupId>org.apache.storm</groupId>
<version>3.0.0-SNAPSHOT</version>
<version>3.0.0</version>
<relativePath>../pom.xml</relativePath>
</parent>

Expand Down
2 changes: 1 addition & 1 deletion storm-dist/binary/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
<parent>
<artifactId>storm-dist</artifactId>
<groupId>org.apache.storm</groupId>
<version>3.0.0-SNAPSHOT</version>
<version>3.0.0</version>
<relativePath>../pom.xml</relativePath>
</parent>

Expand Down
2 changes: 1 addition & 1 deletion storm-dist/binary/storm-autocreds-bin/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
<parent>
<groupId>org.apache.storm</groupId>
<artifactId>apache-storm-bin</artifactId>
<version>3.0.0-SNAPSHOT</version>
<version>3.0.0</version>
</parent>
<artifactId>storm-autocreds-bin</artifactId>
<packaging>pom</packaging>
Expand Down
2 changes: 1 addition & 1 deletion storm-dist/binary/storm-client-bin/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
<parent>
<artifactId>apache-storm-bin</artifactId>
<groupId>org.apache.storm</groupId>
<version>3.0.0-SNAPSHOT</version>
<version>3.0.0</version>
<relativePath>../pom.xml</relativePath>
</parent>

Expand Down
2 changes: 1 addition & 1 deletion storm-dist/binary/storm-kafka-monitor-bin/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
<parent>
<groupId>org.apache.storm</groupId>
<artifactId>apache-storm-bin</artifactId>
<version>3.0.0-SNAPSHOT</version>
<version>3.0.0</version>
</parent>
<artifactId>storm-kafka-monitor-bin</artifactId>
<packaging>pom</packaging>
Expand Down
2 changes: 1 addition & 1 deletion storm-dist/binary/storm-submit-tools-bin/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
<parent>
<groupId>org.apache.storm</groupId>
<artifactId>apache-storm-bin</artifactId>
<version>3.0.0-SNAPSHOT</version>
<version>3.0.0</version>
</parent>
<artifactId>storm-submit-tools-bin</artifactId>
<packaging>pom</packaging>
Expand Down
Loading
Loading