Optimize ZooKeeper read requests and remove redundant checks#8714
Merged
reiabreu merged 2 commits intoMay 31, 2026
Merged
Conversation
reiabreu
reviewed
May 31, 2026
|
|
||
| state.close(); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
There is no test case that does: getData(path, watch=true) on a missing node, then creates the node, and verifies the callback was triggered,
What do you thinking about adding it?
Contributor
Author
There was a problem hiding this comment.
Thank you! I've committed the missing test case.
This test is crucial for preventing regressions. It verifies that if a getData call to zk fails with watched clause enabled, the fallback mechanism successfully registers the watcher manually (calling the method existsNode).
reiabreu
approved these changes
May 31, 2026
rzo1
approved these changes
May 31, 2026
Contributor
|
Thanks for this contribution @GGraziadei |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Refactoring ZooKeeper reads to optimize request volume. Removed unnecessary
.exists()calls by handling missing nodes reactively. More details in the linked issue.Proposed reading pattern
How was the change tested
gestVersionIn the context of #8712