Skip to content

[SPARK-58193][SQL] Classify Databricks syntax errors by message #57333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alekjarmov wants to merge 4 commits into from
+13 −3
Closed

[SPARK-58193][SQL] Classify Databricks syntax errors by message #57333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ea4b656
[MINOR][SQL] Classify Databricks syntax errors by message
alekjarmov Jul 17, 2026
52471af
[MINOR][SQL] Match Databricks syntax errors case-insensitively
alekjarmov Jul 17, 2026
f10335e
[MINOR][SQL] Organize Databricks syntax error tests
alekjarmov Jul 17, 2026
f89739a
[MINOR][SQL] Name Databricks syntax test after SPARK-58193
alekjarmov Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions sql/core/src/main/scala/org/apache/spark/sql/jdbc/DatabricksDialect.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,12 @@ private case class DatabricksDialect() extends JdbcDialect with NoLegacyJDBCErro
case _ => None
}

// See https://docs.databricks.com/aws/en/error-messages/sqlstates
// See https://docs.databricks.com/aws/en/error-messages/sqlstates.
// The driver may report syntax errors with a non-class-42 SQLState.
override def isSyntaxErrorBestEffort(exception: SQLException): Boolean = {
Option(exception.getSQLState).exists(_.startsWith("42"))
Option(exception.getSQLState).exists(_.startsWith("42")) ||
Option(exception.getMessage)
.exists(_.toUpperCase(Locale.ROOT).contains("SYNTAX_ERROR"))
}

override def quoteIdentifier(colName: String): String = {
Expand Down
9 changes: 8 additions & 1 deletion sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
package org.apache.spark.sql.jdbc

import java.math.BigDecimal
import java.sql.{Connection, Date, DriverManager, ResultSet, Statement, Timestamp}
import java.sql.{Connection, Date, DriverManager, ResultSet, SQLException, Statement, Timestamp}
import java.time.{Instant, LocalDate, LocalDateTime}
import java.time.format.DateTimeFormatter
import java.util.{Calendar, GregorianCalendar, Properties, TimeZone}
Expand Down Expand Up @@ -2608,6 +2608,13 @@ class JDBCSuite extends SharedSparkSession {
.getJDBCType(BinaryType).map(_.databaseTypeDefinition).get == "BINARY")
}

test("SPARK-58193: DatabricksDialect syntax error detection") {
val dialect = DatabricksDialect()
assert(dialect.isSyntaxErrorBestEffort(
new SQLException("[parse_syntax_error] Syntax error at or near 'SQL'", "07000")))
assert(!dialect.isSyntaxErrorBestEffort(new SQLException("Connection reset", "08001")))
}

test("SPARK-45425: Mapped TINYINT to ShortType for MsSqlServerDialect") {
val msSqlServerDialect = JdbcDialects.get("jdbc:sqlserver")
val metadata = new MetadataBuilder().putLong("scale", 1)
Expand Down