[SPARK-57806][SQL] Fix coercion of NullTyped expressions#56927
Draft
eejbyfeldt wants to merge 1 commit into
Draft
[SPARK-57806][SQL] Fix coercion of NullTyped expressions#56927eejbyfeldt wants to merge 1 commit into
eejbyfeldt wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Instead of replacing the Nulltyped value with a literal a cast is introduced. The optimizer can later constant fold this when that safe to do.
Why are the changes needed?
The current behavior is not safe for expressions that might raise an error as the expression get removed.
Does this PR introduce any user-facing change?
Yes, fixes correctness issue.
How was this patch tested?
Existing a new tests.
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude sonnet 4.6