Skip to content

JavaBinCodec: fix self-suppression risk #4489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dsmiley merged 1 commit into from
Jun 3, 2026
+4 −1
Merged

JavaBinCodec: fix self-suppression risk #4489

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion solr/solrj/src/java/org/apache/solr/common/util/JavaBinCodec.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1481,7 +1481,10 @@ public String get(StringBytes b) {

@Override
public void close() throws IOException {
if (daos != null) {
// marshal() already flushes in its own finally block, so skip the redundant flush.
// Flushing again after a marshal failure would re-throw the same exception from the broken
// stream, causing "Self-suppression not permitted" in the caller's try-with-resources.
if (daos != null && !alreadyMarshalled) {
daos.flushBuffer();
}
}
Expand Down
Loading