Skip to content

SOLR-17697 Use picocli instead of commons-cli#3254

Draft
janhoy wants to merge 7 commits intomainfrom
jira/SOLR-17697-picocli
Draft

SOLR-17697 Use picocli instead of commons-cli#3254
janhoy wants to merge 7 commits intomainfrom
jira/SOLR-17697-picocli

Conversation

@janhoy
Copy link
Copy Markdown
Contributor

@janhoy janhoy commented Mar 11, 2025

https://issues.apache.org/jira/browse/SOLR-17697

This PR is just a way to visualize the status of the feature branch jira/SOLR-17697-picocli.
Create PRs targeting that branch to tackle individual tasks, and then squash merge into this feature branch once done. Then at the end this branch can be merged (not-squash) into main to preserve each tool porting.

Pick a tool not yet converted from the list below. You'll find a useful LLM prompt template in the JIRA issue linked above. Feel free to link your PR number next to the tool line below to signal that you are working on it. Once merged into the feature-branch, check the checkbox.

Tasks/milestones:

@xtenzQ
Copy link
Copy Markdown
Contributor

xtenzQ commented Mar 21, 2025

Actually, I'd like to try to implement PoC for few initial tools.

upd: oh, I didnt notice there is a PR created for this

@janhoy
Copy link
Copy Markdown
Contributor Author

janhoy commented Mar 21, 2025

upd: oh, I didnt notice there is a PR created for this

Yea, there's an in-progress exploration taking place, feel free to join the discussion about it or POC for yourself on how to solve various issues that arise. We're still trying to land on the most elegant way to introduce things, and I plan to dial down the ambitions for the other PR to do bare minimal for one or two tools, and perhaps the "start" tool. Eventually, when we start getting the grip on how things should flow, it will be easier to jump in and implement PRs for new tools, targeting this branch.

@janhoy janhoy force-pushed the jira/SOLR-17697-picocli branch from 4ddb026 to 97a673e Compare April 5, 2026 12:45
@janhoy janhoy force-pushed the jira/SOLR-17697-picocli branch from 97a673e to cb41a69 Compare April 5, 2026 12:50
@epugh
Copy link
Copy Markdown
Contributor

epugh commented Apr 5, 2026

Let's get this into main as soon as possible!!!

@janhoy
Copy link
Copy Markdown
Contributor Author

janhoy commented Apr 7, 2026

@xtenzQ Everything is now brought up to speed with main. I have merged the first few tools into the feature branch. And I have two in-flight PRs ready for review and merging into this branch. See a comment in the JIRA issue for how to contribute for other tools not yet converted.

@github-actions github-actions bot added the tests label Apr 7, 2026
}

private void printVersion() {
CLIO.out("Solr version is: " + SolrVersion.LATEST);
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We talked about whether solr version should print the version of backend Solr, while solr --version prints the version of the CLI tool itself. This probably deserveds its own JIRA...

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I knew we had a JIRA for this - here it is. Resolving this conversation here
https://issues.apache.org/jira/browse/SOLR-17318

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants