Conversation
|
Actually, I'd like to try to implement PoC for few initial tools. upd: oh, I didnt notice there is a PR created for this |
Yea, there's an in-progress exploration taking place, feel free to join the discussion about it or POC for yourself on how to solve various issues that arise. We're still trying to land on the most elegant way to introduce things, and I plan to dial down the ambitions for the other PR to do bare minimal for one or two tools, and perhaps the "start" tool. Eventually, when we start getting the grip on how things should flow, it will be easier to jump in and implement PRs for new tools, targeting this branch. |
4ddb026 to
97a673e
Compare
97a673e to
cb41a69
Compare
|
Let's get this into main as soon as possible!!! |
|
@xtenzQ Everything is now brought up to speed with main. I have merged the first few tools into the feature branch. And I have two in-flight PRs ready for review and merging into this branch. See a comment in the JIRA issue for how to contribute for other tools not yet converted. |
| } | ||
|
|
||
| private void printVersion() { | ||
| CLIO.out("Solr version is: " + SolrVersion.LATEST); |
There was a problem hiding this comment.
We talked about whether solr version should print the version of backend Solr, while solr --version prints the version of the CLI tool itself. This probably deserveds its own JIRA...
There was a problem hiding this comment.
I knew we had a JIRA for this - here it is. Resolving this conversation here
https://issues.apache.org/jira/browse/SOLR-17318
https://issues.apache.org/jira/browse/SOLR-17697
This PR is just a way to visualize the status of the feature branch
jira/SOLR-17697-picocli.Create PRs targeting that branch to tackle individual tasks, and then squash merge into this feature branch once done. Then at the end this branch can be merged (not-squash) into main to preserve each tool porting.
Pick a tool not yet converted from the list below. You'll find a useful LLM prompt template in the JIRA issue linked above. Feel free to link your PR number next to the tool line below to signal that you are working on it. Once merged into the feature-branch, check the checkbox.
Tasks/milestones: