Enhancement: support for remembered principals in session management, check w… - #2859
Merged
Conversation
…hether url rewriting enabled in more places
steinarb
reviewed
Aug 15, 2026
| /** | ||
| * Sets whether the constructed {@code Subject} instance should was constructed from remembered principals | ||
| */ | ||
| default void setRememberedPrincipals(boolean rememberedPrincipals) { } |
Contributor
There was a problem hiding this comment.
Value not saved? Are there context subclasses, some of which store the value?
(hm... but these are new methods so if there were subclasses implementing, they should have been shown here...?)
Contributor
Author
There was a problem hiding this comment.
Yes. The issue is you cannot just add methods to interfaces without breaking compatibility.
They need to have default implementation (empty here)
This is implemented in DefaultSubjectContext
Actually, these should throw an exception. I will make it so.
Thanks for the hint
… thus forcing the implementation to override it
fpapon
approved these changes
Aug 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…hether url rewriting enabled in more places
Also refactored and improved the code along the way
Following this checklist to help us incorporate your contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a GitHub issue. Your pull request should address just this issue, without pulling in other changes.
[#XXX] - Fixes bug in SessionManager,where you replace
#XXXwith the appropriate GitHub issue. Best practiceis to use the GitHub issue title in the pull request title and in the first line of the commit message.
fixes #XXXif merging the PR should close a related issue.mvn verifyto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.Trivial changes like typos do not require a GitHub issue (javadoc, comments...).
In this case, just format the pull request title like
[DOC] - Add javadoc in SessionManager.If this is your first contribution, you have to read the Contribution Guidelines
If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement
if you are unsure please ask on the developers list.
To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.