Skip to content

Enhancement: support for remembered principals in session management, check w… - #2859

Merged
lprimak merged 2 commits into
apache:mainfrom
lprimak:remember-me-session-fix
Aug 16, 2026
Merged

Enhancement: support for remembered principals in session management, check w…#2859
lprimak merged 2 commits into
apache:mainfrom
lprimak:remember-me-session-fix

Conversation

@lprimak

@lprimak lprimak commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

…hether url rewriting enabled in more places
Also refactored and improved the code along the way

Following this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GitHub issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a GitHub issue. Your pull request should address just this issue, without pulling in other changes.
  • Format the pull request title like [#XXX] - Fixes bug in SessionManager,
    where you replace #XXX with the appropriate GitHub issue. Best practice
    is to use the GitHub issue title in the pull request title and in the first line of the commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • add fixes #XXX if merging the PR should close a related issue.
  • Run mvn verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • Committers: Make sure a milestone is set on the PR
  • Committers: Use "Squash and Merge" to combine all commits into one when merging a PR when appropriate.

Trivial changes like typos do not require a GitHub issue (javadoc, comments...).
In this case, just format the pull request title like [DOC] - Add javadoc in SessionManager.

If this is your first contribution, you have to read the Contribution Guidelines

If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement
if you are unsure please ask on the developers list.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@lprimak lprimak added this to the 3.0.1 milestone Aug 15, 2026
@lprimak lprimak self-assigned this Aug 15, 2026
@github-actions github-actions Bot added the java Pull requests that update Java code label Aug 15, 2026
@lprimak lprimak changed the title enh: support for remembered principals in session management, check w… Enhancement: support for remembered principals in session management, check w… Aug 15, 2026
/**
* Sets whether the constructed {@code Subject} instance should was constructed from remembered principals
*/
default void setRememberedPrincipals(boolean rememberedPrincipals) { }

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Value not saved? Are there context subclasses, some of which store the value?
(hm... but these are new methods so if there were subclasses implementing, they should have been shown here...?)

@lprimak lprimak Aug 15, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. The issue is you cannot just add methods to interfaces without breaking compatibility.
They need to have default implementation (empty here)
This is implemented in DefaultSubjectContext
Actually, these should throw an exception. I will make it so.
Thanks for the hint

… thus forcing the implementation to override it
@lprimak
lprimak merged commit 7cb2054 into apache:main Aug 16, 2026
16 checks passed
@lprimak
lprimak deleted the remember-me-session-fix branch August 16, 2026 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

java Pull requests that update Java code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants