Skip to content

Bugfix: default case insensitive filters for programmatic and Spring / Spring Boot configurations - #2857

Open
lprimak wants to merge 2 commits into
apache:mainfrom
lprimak:default-case-insensitive-filters
Open

Bugfix: default case insensitive filters for programmatic and Spring / Spring Boot configurations#2857
lprimak wants to merge 2 commits into
apache:mainfrom
lprimak:default-case-insensitive-filters

Conversation

@lprimak

@lprimak lprimak commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

This is a bug fix. During programmatic instantiation, or with Spring / Spring Boot without shiro.ini, the default behavior remained case-sensitive matching, which is incorrect and doesn't match the documentation for Shiro 3.x

Finder Credit: 0xCc.zhang

Following this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GitHub issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a GitHub issue. Your pull request should address just this issue, without pulling in other changes.
  • Format the pull request title like [#XXX] - Fixes bug in SessionManager,
    where you replace #XXX with the appropriate GitHub issue. Best practice
    is to use the GitHub issue title in the pull request title and in the first line of the commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • add fixes #XXX if merging the PR should close a related issue.
  • Run mvn verify to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • Committers: Make sure a milestone is set on the PR
  • Committers: Use "Squash and Merge" to combine all commits into one when merging a PR when appropriate.

Trivial changes like typos do not require a GitHub issue (javadoc, comments...).
In this case, just format the pull request title like [DOC] - Add javadoc in SessionManager.

If this is your first contribution, you have to read the Contribution Guidelines

If your pull request is about ~20 lines of code you don't need to sign an Individual Contributor License Agreement
if you are unsure please ask on the developers list.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@lprimak lprimak added this to the 3.0.1 milestone Aug 14, 2026
@lprimak lprimak self-assigned this Aug 14, 2026
@github-actions github-actions Bot added java Pull requests that update Java code tests labels Aug 14, 2026
@lprimak lprimak changed the title Default case insensitive filters Default case insensitive filters for programmatic and Spring / Spring Boot instantiation Aug 14, 2026
@lprimak lprimak changed the title Default case insensitive filters for programmatic and Spring / Spring Boot instantiation Default case insensitive filters for programmatic and Spring / Spring Boot configurations Aug 14, 2026
@lprimak lprimak changed the title Default case insensitive filters for programmatic and Spring / Spring Boot configurations Bugfix: default case insensitive filters for programmatic and Spring / Spring Boot configurations Aug 15, 2026
Comment thread core/src/main/java/org/apache/shiro/util/AntPathMatcher.java
Comment thread core/src/main/java/org/apache/shiro/util/AntPathMatcher.java
Comment thread core/src/main/java/org/apache/shiro/util/AntPathMatcher.java

@steinarb steinarb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

java Pull requests that update Java code tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants