[ISSUE #6842] Handle missing data in HTTP long-polling responses - #6979
Open
yykaue wants to merge 2 commits into
Open
[ISSUE #6842] Handle missing data in HTTP long-polling responses#6979yykaue wants to merge 2 commits into
yykaue wants to merge 2 commits into
Conversation
Aias00
reviewed
Aug 26, 2026
Aias00
left a comment
Contributor
There was a problem hiding this comment.
This now treats admin error payloads as successful no-change responses. The admin exception handlers return ShenyuAdminResult.error(...) bodies such as {"code":500,"message":"..."} without setting a non-200 HTTP status, and this branch returns as soon as data is missing/null before checking the result code. In HttpLongPollingTask, only exceptions from doLongPolling trigger the retry/backoff path, so a listener-side error body can now be swallowed as no change and the loop immediately continues. Could we check code first and throw/retry when it is present and not CommonErrorCode.SUCCESSFUL, then only ignore missing/null data for successful responses?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the null handling in
HttpSyncDataService.doLongPolling().HTTP long-polling responses without configuration change data are now treated as “no change” instead of causing an exception.
The following response cases are handled:
datafield is missing.datafield isnull.null.Valid
dataarrays continue to use the existing processing flow.Closes #6842
@Aias00, could you please help review this PR? Thanks!