Skip to content

[ISSUE #9777 ]feat: use data version from master while sync slave and fix delete co…#9778

Merged
RongtongJin merged 6 commits intoapache:developfrom
absolute8511:fix-sync-slave
Apr 9, 2026
Merged

[ISSUE #9777 ]feat: use data version from master while sync slave and fix delete co…#9778
RongtongJin merged 6 commits intoapache:developfrom
absolute8511:fix-sync-slave

Conversation

@absolute8511
Copy link
Copy Markdown
Contributor

…nfig while sync

Change-Id: I42b2e7b1acc6836d3c90973801c9defba5f1325c

Which Issue(s) This PR Fixes

Fixes #9777

Brief Description

How Did You Test This Change?

…nfig while sync

Change-Id: I42b2e7b1acc6836d3c90973801c9defba5f1325c
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Oct 23, 2025

Codecov Report

❌ Patch coverage is 22.72727% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.29%. Comparing base (2eb2129) to head (9838025).

Files with missing lines Patch % Lines
...ker/config/v1/RocksDBSubscriptionGroupManager.java 0.00% 6 Missing ⚠️
...mq/broker/config/v1/RocksDBTopicConfigManager.java 0.00% 6 Missing ⚠️
...ocketmq/broker/config/v1/RocksDBConfigManager.java 0.00% 4 Missing ⚠️
...apache/rocketmq/broker/slave/SlaveSynchronize.java 75.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #9778      +/-   ##
=============================================
- Coverage      48.32%   48.29%   -0.04%     
+ Complexity     12234    12224      -10     
=============================================
  Files           1313     1313              
  Lines          93639    93655      +16     
  Branches       12006    12006              
=============================================
- Hits           45254    45226      -28     
- Misses         42788    42824      +36     
- Partials        5597     5605       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@absolute8511 absolute8511 changed the title feat: use data version from master while sync slave and fix delete co… [#ISSUE9777 ]feat: use data version from master while sync slave and fix delete co… Oct 23, 2025
@absolute8511 absolute8511 changed the title [#ISSUE9777 ]feat: use data version from master while sync slave and fix delete co… [ISSUE #9777 ]feat: use data version from master while sync slave and fix delete co… Oct 23, 2025
Change-Id: I7ec20607a84499fe5a6607763013c59d726aedc3
Change-Id: Ic845794350e8bdaa847bdd0ae4b3e40ab1ad6311
Change-Id: I39e78477a5223b578a4ede3e5cb76f04368d1ca3
Change-Id: Iebe28ffcd7946ee865daf1a8f01f43483244d541
Change-Id: I9e835568912928ddf6e81816095ee3ed8f93afc0
@Silencesk
Copy link
Copy Markdown

Silencesk commented Apr 1, 2026

  • 建议在5.5.0中把这两个PR #9778 + #9996合并进去,目前我们在引进5.x时,也出现了同样的问题
  • 问题现象比较严重:
    • 从节点磁盘写入比主节点高很多
    • 并且产生了fullgc
  • 其中topic数4000+,group数6000+;在LiteTopic场景中这个问题应该会更为严重
  • @lizhimins @RongtongJin @absolute8511 @humkum

@RongtongJin RongtongJin merged commit 2b5e709 into apache:develop Apr 9, 2026
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Should not update topic config data version while sync slave use master instead

4 participants