[ISSUE #11180] Reject wrapped POP ACK offsets - #11181
Open
beautyarbutin wants to merge 1 commit into
Open
beautyarbutin wants to merge 1 commit into
beautyarbutin wants to merge 1 commit into
Conversation
RockteMQ-AI
approved these changes
Sep 19, 2026
RockteMQ-AI
left a comment
RockteMQ-AI
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Small change, looks good.
Automated review by github-manager-bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Issue(s) This PR Fixes
Brief Description
PopCheckPoint.indexOfAcknarrowed the difference between an ACK offset and the checkpoint start offset fromlongtointbefore matching it againstqueueOffsetDiff. A difference larger thanInteger.MAX_VALUEcould therefore wrap to a valid popped-message offset and acknowledge the wrong checkpoint entry.Keep the difference as a
long, reject negative or non-representable values before narrowing, and add a regression test covering normal, before-start, and wrapped ACK offsets.How Did You Test This Change?
mvn -B -pl store -am -DskipITs -Dtest=PopCheckPointTest -Dsurefire.failIfNoSpecifiedTests=false testmvn -B -pl store -am -DskipITs test