RANGER-5559: fixes to docker container startup as non-root user and/or hostname as non "ranger"#922
Open
sneethiraj wants to merge 2 commits intoapache:masterfrom
Open
RANGER-5559: fixes to docker container startup as non-root user and/or hostname as non "ranger"#922sneethiraj wants to merge 2 commits intoapache:masterfrom
sneethiraj wants to merge 2 commits intoapache:masterfrom
Conversation
…t user and also fixed hardcoded hostname in create service script
…ATE_SAMPLE_SERVICES as true in env
mneethiraj
reviewed
Apr 22, 2026
| if not current_host_name: | ||
| current_host_name = "ranger" | ||
|
|
||
| ranger_client = RangerClient('http://' + current_host_name + ':6080', ('admin', 'rangerR0cks!')) |
Contributor
There was a problem hiding this comment.
Given this script is executed in the container running ranger admin service, it seem call to socket.gethostname() is not necessary; simply using localhost would work, right?
| import sys | ||
|
|
||
| ranger_client = RangerClient('http://ranger:6080', ('admin', 'rangerR0cks!')) | ||
| skipMe = os.getenv("SKIP_CREATE_SAMPLE_SERVICES","false").lower() == "true" |
Contributor
There was a problem hiding this comment.
@sneethiraj - for developer testing, I think it is okay to create services during Ranger admin startup. However, this change would be useful in the official docker image released to docker hub, which is built from https://github.com/apache/ranger-tools/tree/main/release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As startup script is trying to move files into /etc/init.d and /usr/bin, it is throwing lot of errors.
Also, having hardcoded hostname as ranger during service creation causes more errors during startup.
What changes were proposed in this pull request?
Those steps that requires root permission WILL run only if you are a root. This will be required for non-docker setp.
Also, ranger service creation script uses the current hostname to identify the service instead of hardcoded 'ranger'
How was this patch tested?
Build and deployed as a docker container in Linux Microk8s environment. It deploys fine with no errors.