Skip to content

Fix segment status sorting in table UI#18609

Open
wolfkill wants to merge 1 commit into
apache:masterfrom
wolfkill:fix/segment-status-sort
Open

Fix segment status sorting in table UI#18609
wolfkill wants to merge 1 commit into
apache:masterfrom
wolfkill:fix/segment-status-sort

Conversation

@wolfkill
Copy link
Copy Markdown
Contributor

Summary

  • unwrap rendered table cell values when sorting Status columns
  • avoid mutating table state in place for static sort functions

Why

The Segments table renders status cells as objects with a display value and a custom renderer. Lodash sorting on the object itself keeps the visible status order unchanged.

Fixes #14570.

Tests

  • npm run build-dev
  • npm run build
  • git diff --check
  • verified object-backed Status rows sort ascending and descending by their value

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.78%. Comparing base (9f8eb1a) to head (4c08a66).
⚠️ Report is 3 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (9f8eb1a) and HEAD (4c08a66). Click for more details.

HEAD has 4 uploads less than BASE
Flag BASE (9f8eb1a) HEAD (4c08a66)
java-21 5 4
unittests 2 1
temurin 5 4
unittests2 1 0
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #18609      +/-   ##
============================================
- Coverage     64.37%   56.78%   -7.59%     
+ Complexity     1137        7    -1130     
============================================
  Files          3335     2567     -768     
  Lines        206065   149121   -56944     
  Branches      32136    24106    -8030     
============================================
- Hits         132649    84680   -47969     
+ Misses        62760    57250    -5510     
+ Partials      10656     7191    -3465     
Flag Coverage Δ
custom-integration1 100.00% <ø> (ø)
integration 100.00% <ø> (ø)
integration1 100.00% <ø> (ø)
integration2 0.00% <ø> (ø)
java-21 56.78% <ø> (-7.59%) ⬇️
temurin 56.78% <ø> (-7.59%) ⬇️
unittests 56.78% <ø> (-7.59%) ⬇️
unittests1 56.78% <ø> (+0.01%) ⬆️
unittests2 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[UI] Sorting on the segments status is not working

2 participants