Skip to content

PHOENIX-7566 HAGroupStore admin tool: HDFS URLs, URL validation, failover recovery guidance #2519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ritegarg wants to merge 4 commits into
base: PHOENIX-7562-feature-new
Choose a base branch
from
+405 −47
Open

PHOENIX-7566 HAGroupStore admin tool: HDFS URLs, URL validation, failover recovery guidance #2519

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f39678c
PHOENIX-7566 HAGroupStore admin tool: HDFS URLs, URL validation, cano…
Jun 11, 2026
945972c
PHOENIX-7566 HAGroupStore admin tool: address review feedback
Jun 12, 2026
4d08c8c
PHOENIX-7566 HAGroupStore admin tool: review follow-ups (docs + URL f…
Jun 12, 2026
bed29dd
PHOENIX-7566 HAGroupStore admin tool: keep ZK URL validation strict
Jun 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 19 additions & 14 deletions phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/HAGroupStoreClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,23 +216,28 @@ public static List<String> getHAGroupNames(String zkUrl) throws SQLException {
PhoenixConnection conn = (PhoenixConnection) DriverManager
.getConnection(JDBC_PROTOCOL_ZK + JDBC_PROTOCOL_SEPARATOR + zkUrl);
Statement stmt = conn.createStatement(); ResultSet rs = stmt.executeQuery(queryString)) {
// Format the local zkUrl once and strictly: a malformed own URL is a hard error.
String formattedZkUrl = JDBCUtil.formatUrl(zkUrl, RegistryType.ZK);
while (rs.next()) {
String haGroupName = rs.getString(HA_GROUP_NAME);
String zkUrl1 = rs.getString(ZK_URL_1);
String zkUrl2 = rs.getString(ZK_URL_2);
String formattedZkUrl1 = null;
String formattedZkUrl2 = null;
if (StringUtils.isNotBlank(zkUrl1)) {
formattedZkUrl1 = JDBCUtil.formatUrl(zkUrl1, RegistryType.ZK);
}
if (StringUtils.isNotBlank(zkUrl2)) {
formattedZkUrl2 = JDBCUtil.formatUrl(zkUrl2, RegistryType.ZK);
}
String formattedZkUrl = JDBCUtil.formatUrl(zkUrl, RegistryType.ZK);
if (
StringUtils.equals(formattedZkUrl1, formattedZkUrl)
|| StringUtils.equals(formattedZkUrl2, formattedZkUrl)
) {
result.add(rs.getString(HA_GROUP_NAME));
try {
String formattedZkUrl1 =
StringUtils.isNotBlank(zkUrl1) ? JDBCUtil.formatUrl(zkUrl1, RegistryType.ZK) : null;
String formattedZkUrl2 =
StringUtils.isNotBlank(zkUrl2) ? JDBCUtil.formatUrl(zkUrl2, RegistryType.ZK) : null;
if (
StringUtils.equals(formattedZkUrl1, formattedZkUrl)
|| StringUtils.equals(formattedZkUrl2, formattedZkUrl)
) {
result.add(haGroupName);
}
} catch (RuntimeException e) {
// One row with an unparseable ZK URL must not break enumeration for any caller (admin
// `list`, PhoenixRegionServerEndpoint, ReplicationLogReplayService). Skip just that row.
LOGGER.warn("Skipping HA group row '{}' with unparseable ZK URL (zkUrl1={}, zkUrl2={})",
haGroupName, zkUrl1, zkUrl2, e);
}
}
}
Expand Down
Loading