release resources in COSOutputStream#462
Open
valerybokov wants to merge 1 commit into
Open
Conversation
|
Since filters is passed in from outside, COSOutputStream doesn't own it — won't clear() here risk surprising the caller? |
Contributor
|
Yeah why not just set it to null. |
Author
Yeah, my bad. |
Author
This is good idea, but it is final. Can we set it as not final? |
|
given how short-lived COSOutputStream is I don't see the benefit in removing final from filters just to ensure nulling filters. It will be GC'd anyway as soon as the COSOutputStream reference is no longer held |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.