[python][ray] Incrementally commit update_by_row_id file groups#8826
Draft
XiaoHongbo-Hope wants to merge 8 commits into
Draft
[python][ray] Incrementally commit update_by_row_id file groups#8826XiaoHongbo-Hope wants to merge 8 commits into
XiaoHongbo-Hope wants to merge 8 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
For large
update_by_row_idjobs, a single final commit makes late failures expensive because all uncommitted file groups must be rewritten.Add an optional
max_groups_per_committo make completed windows durable and reduce retry work. The default remains a single atomic commit; incremental mode preserves cleanup and conflict detection but may retain earlier windows after a later failure.Tests
RayUpdateByRowIdTestTestRowIdBaseEntriesCacheTestCheckRowIdFromSnapshotTestFileStoreCommitCommitCallbackTestTestRESTCommit