-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[python][ray] Support multi-clause fall-through in merge_into #8115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
XiaoHongbo-Hope
wants to merge
12
commits into
apache:master
Choose a base branch
from
XiaoHongbo-Hope:support_multi_clause
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+432
−60
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
3682611
[ray] Support multi-clause fall-through in merge_into
XiaoHongbo-Hope cfcb28d
[ray] Fix NULL row loss, strengthen first-wins test, hoist imports
XiaoHongbo-Hope be2def2
[ray] Fail fast on duplicate source rows in multi-clause matched path
XiaoHongbo-Hope a663c5c
[ray] Remove redundant row_id_col assignment in loop
XiaoHongbo-Hope 0efaebd
[ray] Move duplicate check to per-clause matched rows
XiaoHongbo-Hope 7b6a6d2
[ray] Add batch-level duplicate check for multi-clause matched path
XiaoHongbo-Hope 4863454
[ray] Drop mode='all' from count_distinct for consistency
XiaoHongbo-Hope 0ad7055
[ray] Remove batch-level duplicate check, keep per-clause only
XiaoHongbo-Hope ab75099
[ray] Use condition complement for matched remaining, not _ROW_ID
XiaoHongbo-Hope b5508cf
[ray] Hoist on_map construction outside preparation loop
XiaoHongbo-Hope 9d522a8
[ray] Add matched-path NULL fall-through test for multi-clause
XiaoHongbo-Hope d35f795
[ray] Reject unconditional non-last clause in merge_into
XiaoHongbo-Hope File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-blocking test gap: the not-matched path covers NULL condition fall-through, but the matched path relies on the same
COALESCE(NOT (...), TRUE)behavior here. Consider adding a matched-path NULL fall-through test to lock this down.