[core] Don't allow full compaction with lookup changelog producer#7999
Merged
Merged
Conversation
Member
Author
|
cc @JingsongLi thanks! |
Contributor
|
Thanks for the fix. I am holding off on approval for now because the current CI status has failing build/build_test jobs. Please fix or rerun the failures first. |
Member
Author
|
Thank you so much for the review! The failures seem unrelated, would it be possible to rerun them |
ArnavBalyan
force-pushed
the
arnavb/conversion-issue-1
branch
2 times, most recently
from
eb8965d to
6e9e332
Compare
ArnavBalyan
force-pushed
the
arnavb/conversion-issue-1
branch
from
6e9e332 to
c64bd95
Compare
Contributor
|
I reviewed this PR as part of a pass over recent open non-draft Paimon PRs. I did not find any clear correctness, compatibility, or regression issue to flag from the current diff. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Tests