HDDS-13110. Add SCM metric for number of blocks deleted#10768
Open
priyeshkaratha wants to merge 1 commit into
Open
HDDS-13110. Add SCM metric for number of blocks deleted#10768priyeshkaratha wants to merge 1 commit into
priyeshkaratha wants to merge 1 commit into
Conversation
priyeshkaratha
marked this pull request as ready for review
July 15, 2026 02:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
SCM's
ScmBlockDeletingServiceMetricscurrently exposes only transaction-level deletion metrics, such asnumBlockDeletionTransactionCreatedandnumBlockDeletionTransactionCompleted. This makes it difficult to measure actual block deletion throughput.This PR adds a new metric,
numBlocksDeleted(scm_block_deleting_service_metrics_num_blocks_deleted), which counts the total number of blocks deleted once a delete transaction has been fully acknowledged by all replicas and removed from the deleted-block log.Since datanode acknowledgements only contain the transaction ID, container ID, and status, SCM tracks the block count using an in-memory
transactionToBlockCountMap(txID → block count). The map is populated when transactions are prepared for sending and consumed when transactions are completed, covering both the normal ACK path and the container deleted/not-found path.This approach avoids RocksDB lookups during commit and does not rely on the existing
txSizeMap, which is only populated for newer layout versions. Removing entries after use ensures each transaction is counted exactly once, even with retries or duplicate acknowledgements. The added work is O(1) and has no measurable impact on deletion performance.What is the link to the Apache JIRA
HDDS-13110
How was this patch tested?
Tested manually and using mini ozone cluster in code
Generated by AI