HDDS-14933. Disambiguate metrics and JMX registrations for same-JVM ozone local services#10763
Draft
henrybear327 wants to merge 7 commits into
Draft
HDDS-14933. Disambiguate metrics and JMX registrations for same-JVM ozone local services#10763henrybear327 wants to merge 7 commits into
henrybear327 wants to merge 7 commits into
Conversation
Signed-off-by: Bolin Lin <linbolin1230@gmail.com>
…zone local services
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
ozone local runs SCM, OM, DN, and optionally S3G inside one process. A lot of existing Ozone code assumed one service per JVM, so metrics and JMX objects were registered under fixed global names. Once multiple services lived in the same JVM, those registrations started colliding or leaking across restart.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-14933
How was this patch tested?
https://github.com/apache/ozone/actions/runs/29328690357