HDDS-15692. Keep GitHub Copilot code review enable but disable review_on_push

[peterxcli]

What changes were proposed in this pull request?

#10705 was trying to add the auto copilot review request on PR open, but turn out the the copilot is eagerly giving review of every push(even the pr is draft), which is noisy and annoying.

Also disable the review on push because sometime you might just accidentally pushed a broken commit then a fix checkstyle/pmd commit, but now it's really possible your pr page has two batch of the copilot review on almost the same snapshot of the code/patch, which is a mass.

#10751 (review) is also the reason why need this change.

What is the link to the Apache JIRA

issues.apache.org/jira/browse/HDDS-15692

How was this patch tested?

(Please explain how this patch was tested. Ex: unit tests, manual tests, workflow run on the fork git repo.)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this.)

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[adoroszlai]

Thanks @peterxcli for raising this concern.

• If we remove review_on_push: true, we get initial review, but need to request follow-up manually. Why not make all reviews manual in that case?
• I also find copilot review annoying, so I would be totally fine removing it completely. But others find it useful and discussed using it.
• I did not get any copilot review on my PRs (HDDS-15832. Wait for healthy KDC before starting S3G #10730, HDDS-15786. Intermittent pipeline limit exceeded in debug tests #10738, HDDS-15843. Update upgrade/xcompat tests to use 2.1.1 #10739). Not sure why, maybe it needs to be enabled in personal settings?
• In any case, we should keep review_drafts: true, to avoid unnecessary CI.
• Please make sure to reflect the change in the title. Also, what does [1/2] mean?

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[peterxcli]

If we remove review_on_push: true, we get initial review, but need to request follow-up manually. Why not make all reviews manual in that case?

actually I'm not really sure what would happend(all manually or review on opening) if the copilot is enable and review_on_push is disable

I also find copilot review annoying, so I would be totally fine removing it completely. But others find it useful and discussed using it.

so keep it to review on demand would be the consensus.

I did not get any copilot review on my PRs (#10730, #10738, #10739). Not sure why, maybe it needs to be enabled in personal settings?

I also have no idea.

In any case, we should keep review_drafts: true, to avoid unnecessary CI.

good point, added it back

Please make sure to reflect the change in the title. Also, what does [1/2] mean?

ok, the original "[1/2]" means this is the patch for the same HDDS-15692 ticket which #10705 is the first PR of it.

[jojochuang]

apache's explanation: https://github.com/apache/infrastructure-asfyaml#copilot_code_review which basically maps to:

Github's explanation: https://docs.github.com/en/copilot/how-tos/copilot-on-github/set-up-copilot/configure-automatic-review

[ayushtkn]

Disabling on new pushes, definitely makes sense. I just checked my github profile: https://github.com/settings/copilot/features

and it has 1500 AI credits as budget.

But now I have a doubt, like if it working for me only or for all, because I saw this written there

GitHub Copilot Pro is active for your account

If only people with GitHub Copilot pro can use this and everyone else will be getting messages like above

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Maybe we need to reconsider this & make it manual only, like one who has credits can leverage that. I am having this for free, not sure if ASF gave it or from where.

I was under the assumption that it would be project credits or so. I am even not sure if it is using individual person's credit, then is it fair to use their automatically. Hopefully it isn't any violation of policy or so

@jojochuang can you help check/confirm around this

[ayushtkn]

Not sure why, maybe it needs to be enabled in personal settings?

@adoroszlai can you check here if it shows all repositories, I am just guessing that maybe a reason
https://github.com/settings/copilot/coding_agent