net/sixlowpan: Check if g_frame_hdrlen + IPv6_HDRLEN <= iob->io_len#18857
Open
acassis wants to merge 2 commits into
Open
net/sixlowpan: Check if g_frame_hdrlen + IPv6_HDRLEN <= iob->io_len#18857acassis wants to merge 2 commits into
acassis wants to merge 2 commits into
Conversation
github-actions
Bot
added
Area: Networking
This commit checks if the incoming 6LoWPAN frame header len + the IPv6_HDRLEN will fit inside the b->io_len. Signed-off-by: Alan C. Assis <acassis@gmail.com>
acassis
force-pushed
the
fix_net_6lowpan_again
branch
from
b2c58db to
10cfc96
Compare
cederom
approved these changes
May 8, 2026
Contributor
Author
|
@cederom endofframe is where the received data ends, so the test verifies if this position is lesser than the header len. It is confuse to understand if you don't spend some time looking the code |
There was another small issue on sixlowpan_input.c code, it was processing protosize and 8-bit instead of 16-bit. It was working because the max tcp->tcpoffset was 0xf0, so protosize = ((uint16_t)tcp->tcpoffset >> 4) << 2; Will be protosize = 15 * 4 = 60 and will fit inside 8-bit. Signed-off-by: Alan C. Assis <acassis@gmail.com>
acassis
force-pushed
the
fix_net_6lowpan_again
branch
from
10cfc96 to
2f58087
Compare
linguini1
approved these changes
May 8, 2026
| g_uncomp_hdrlen += protosize; | ||
| return protosize; | ||
|
|
||
| return (int)protosize; |
Contributor
Author
There was a problem hiding this comment.
Good catch, uint16_it is automatically promoted to int.
| goto errout_with_reass; | ||
| } | ||
|
|
||
| protosize = (uint8_t) ret; |
Contributor
There was a problem hiding this comment.
remove space before ret
|
|
||
| static uint16_t sixlowpan_uncompress_ipv6proto(FAR uint8_t *fptr, | ||
| FAR uint8_t *bptr) | ||
| static int sixlowpan_uncompress_ipv6proto(FAR struct iob_s *iob, |
Contributor
There was a problem hiding this comment.
let's return result through FAR uint16_t *?
Contributor
Author
There was a problem hiding this comment.
Do you mean pass protosize as parameter (FAR uint16_t *) and keep int return?
Member
|
Hi: Could you Rebase your PR with the Master Branch? We fixed the Config Error for esp32p4-function-ev-board. Thanks :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix another issue where g_frame_hdrlen is not checked correctly
Impact
Improvement
Testing
$ ./tools/configure.sh b-l475e-iot01a:spirit-6lowpan