{bp-3527} system/uorb: fix listener_top not showing topic data#3547
Merged
Conversation
listener_update() only prints topic data when delta_generation is non-zero (i.e., new data arrived since last check). In listener_top, the first call adds objects to the list, and subsequent calls only print if new data was published between iterations. This results in listener_top -T showing only the header with no topic rows. Fix by always printing the current topic state in listener_update, setting frequency to 0 when no new data arrives. This ensures listener_top displays all topics every iteration. Fixes apache#3202 Signed-off-by: hanzj <hanzhijian@zepp.com>
jerpelea
requested review from
acassis,
cederom,
linguini1,
lupyuen and
xiaoxiang781216
linguini1
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
listener_update() only prints topic data when delta_generation is non-zero (i.e., new data arrived since last check). In listener_top, the first call adds objects to the list, and subsequent calls only print if new data was published between iterations. This results in listener_top -T showing only the header with no topic rows.
Fix by always printing the current topic state in listener_update, setting frequency to 0 when no new data arrives. This ensures listener_top displays all topics every iteration.
Fixes #3202
Impact
RELEASE
Testing
CI