apps: add missing module metadata for executable tools#3519
Draft
aviralgarg05 wants to merge 1 commit into
Draft
apps: add missing module metadata for executable tools#3519aviralgarg05 wants to merge 1 commit into
aviralgarg05 wants to merge 1 commit into
Conversation
Member
|
FYI: I restarted the CI Build to fix the Docker Image |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This patch is one of the smaller upstream slices being extracted from the ongoing GSoC 2026 Dynamic ELF loading and
nxpkgwork for NuttX.An earlier draft PR (#3474) carries the initial
nxpkgpackage lifecycle helper. This PR is a follow-upapps/cleanup from the same broader effort, and it is intended to merge after #3474.Series order for this PR:
The change itself fills in missing module metadata for a small set of executable tools that are already selectable from
apps/, but were still treated as builtin-only in their Kconfig or Makefile paths.Concretely, it:
MODULEassignments for the affected executablesbooltotristatewhere module-capable builds need that distinctionifeq(...,y)toifneq(...,)where the build should accept either builtin or module selectionThe affected commands are limited to existing executable entry points in:
crypto/libtomcryptcrypto/tinycryptdatabase/sqlitelogging/embedlogmath/libtommathsystem/fdtsystem/libuvvideoutils/x264Impact
This makes the affected tools participate correctly in module-capable builds instead of silently behaving as builtin-only selections.
There is no intended functional change for configurations that continue to build these commands in the normal builtin path.
This patch does not change board logic, runtime loader behavior, or package-management behavior. It is limited to
apps/Kconfig and Makefile metadata.Keeping this cleanup separate from the larger Dynamic ELF /
nxpkgseries should make review easier, while still preserving the intended merge order after #3474.Testing
Host:
arm64)xtensa-esp-elf-gcc (crosstool-NG esp-14.2.0_20241119) 14.2.0esptool.py v4.11.0Focused verification for this PR:
xtensaesp32s3-xiao:usbnshapache/nuttxmasterworktree paired with a clean detachedappsworktree at this commitBuild steps:
Build result:
Broader series context:
nxpkgseries, this cleanup was also present in the integrated branch validated on the Seeed XIAO ESP32S3 Senseelf/nxpkgflows for the current seriesThis PR itself only adjusts
appsmodule metadata, so the focused verification for this slice is the clean build above.