netlib: replace DNS ping with gateway ping for connectivity check#3465
Open
zhhyu7 wants to merge 2 commits intoapache:masterfrom
Open
netlib: replace DNS ping with gateway ping for connectivity check#3465zhhyu7 wants to merge 2 commits intoapache:masterfrom
zhhyu7 wants to merge 2 commits intoapache:masterfrom
Conversation
Update the column ruler and field labels in route_ipv6_entry comment to match the actual output: lowercase to uppercase, remove colons. Consistent with Nuttx definition Signed-off-by: zhanghongyu <zhanghongyu@xiaomi.com>
Contributor
|
looks good to me. |
zhhyu7
force-pushed
the
upstream-3
branch
2 times, most recently
from
69a7d17 to
809598e
Compare
simbit18
requested review from
acassis,
anchao,
fdcavalcanti,
jerpelea,
linguini1,
michallenc and
xiaoxiang781216
jerpelea
previously approved these changes
Apr 30, 2026
acassis
requested changes
Apr 30, 2026
|
|
||
| #ifdef CONFIG_NETUTILS_PING | ||
| /** | ||
| * @brief |
Contributor
There was a problem hiding this comment.
Please fix, this is not the Description comment/decoration adopted by NuttX. See netutils/netlib/netlib_checkifconnectivity.c line 50 that you are editing for reference
Comment on lines
+583
to
+594
| /** | ||
| * @brief | ||
| * Check network connectivity by pinging the default gateway | ||
| * of the specified network interface. | ||
| * | ||
| * @param ifname The name of the interface to use | ||
| * @param timeout The timeout of ping | ||
| * @param retry The retry times of ping | ||
| * | ||
| * @return | ||
| * nums of gateway reply of ping; a negative on failure. | ||
| */ |
xiaoxiang781216
previously approved these changes
May 2, 2026
Refactor netlib_check_ipconnectivity() to use gateway/router ping instead of DNS server ping for network connectivity checks. Add IPv6 support. Signed-off-by: zhanghongyu <zhanghongyu@xiaomi.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactor netlib_check_ipconnectivity() to use gateway/router ping instead of DNS server ping for network connectivity checks. Add IPv6 support.
Impact
Testing