Conversation
There was a problem hiding this comment.
Thank you @shtirlic :-) Please provide PR description according to Contributing Guide - provide PR description, impact, and especially testing logs on a real hardware, also git commit signature is missing :-P
I will test on my hardware in a moment as I have this LCD colors problems hopefully here will be the fix :-)
Regarding LVGL the recent release there is LVGL v9.5.0 if you have time after this PR is resolved that would be great! :-)
|
@cederom try to change the RGB, BGR bytes order for data, looks like it swapped, or invert command for display. |
@cederom did you "Luke" the source code? Try to enable CONFIG_LCD_GC9A01_BGR and see if it helps |
Yes tried that already, but its a separate issue and don't want to distract here, thank you @acassis and @shtirlic :-) I am okay with LVGL bump 9.2.1 -> 9.2.2 as it builds and works okay and it just a patch version bump so no internal incompatibilities should arise here, also I like a lot update of versioning from hardcodes to Kconfig provided numbers! Lets just make sure CI build is okay and we follow the CG :-) |
|
Ugh I wrote a reply before but did not send, multitasking is killing focus o_O You can check locally with:
See: https://nuttx.apache.org/docs/latest/contributing/coding_style.html#quick-check-for-compliance :-) |
|
@cederom yeah, looks like I have enabled checks for main repo but not for the apps repo in git hooks |
Update lvlg version to 9.2.2, includes fix for nuttx lcd release Get version from config in Makefile Get version from config in cmake file Signed-off-by: Serg Podtynnyi <serg@podtynnyi.com>
|
@cederom also there is no |
|
@shtirlic you may want to take a look at the new user controlled ci that is currently under development, testing is most welcome, thank you! :-) |


Summary
Impact
There should be no impact,
Testing
Tested by @shtirlic on pico2 on risc-v cores, and by @cederom on FreeBSD with ESP32S3-WS-LCD128 board under development :-)