Skip to content

NIFI-16248 - Merge clustered Connector purge request responses - #11587

Open
skeossei wants to merge 1 commit into
apache:mainfrom
skeossei:NIFI-16248
Open

NIFI-16248 - Merge clustered Connector purge request responses#11587
skeossei wants to merge 1 commit into
apache:mainfrom
skeossei:NIFI-16248

Conversation

@skeossei

Copy link
Copy Markdown
Contributor

Summary

NIFI-16248

Merges asynchronous Connector purge responses across cluster nodes so the purge is reported as finished only after every node completes. This prevents Connector deletion from starting while another node still has queued FlowFiles.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000
  • Pull request contains commits signed with a registered key indicating Verified status

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using ./mvnw clean install -P contrib-check
    • JDK 21
    • JDK 25

Focused verification completed using JDK 21:

  • ConnectorPurgeRequestEndpointMergerTest, StandardHttpResponseMapperTest, and DropRequestEndpointMergerTest: 10 tests passed
  • ClusteredConnectorBacklogIT: 3 tests passed
  • ClusteredConnectorBacklogIT#testClusteredReadQueueAttributesLoadBalancedConnection: 5 consecutive runs passed
  • Targeted nifi-framework-cluster contribution checks passed, including Checkstyle, Apache RAT, and PMD

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

No new dependencies were added, so no LICENSE or NOTICE changes are required.

Documentation

  • Documentation formatting appears as expected in rendered files

No documentation files were changed.

@skeossei
skeossei marked this pull request as ready for review August 24, 2026 20:27

@exceptionfactory exceptionfactory left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this issue @skeossei. The basic addition of the Merger class looks good, I highlighted a handful of stylistic recommendations

@skeossei
skeossei force-pushed the NIFI-16248 branch 2 times, most recently from 5bd55a2 to dc692d5 Compare August 24, 2026 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants