NIFI-16226 - Parameter Context update fails when adding provider-backed inheritance in a cluster - #11562
Open
pvillard31 wants to merge 1 commit into
Open
NIFI-16226 - Parameter Context update fails when adding provider-backed inheritance in a cluster#11562pvillard31 wants to merge 1 commit into
pvillard31 wants to merge 1 commit into
Conversation
…ed inheritance in a cluster
exceptionfactory
left a comment
exceptionfactory
left a comment
Contributor
There was a problem hiding this comment.
Thanks for addressing this issue @pvillard31. I noted one question around inherited parameter handling.
| import static org.mockito.Mockito.when; | ||
|
|
||
| @ExtendWith(MockitoExtension.class) | ||
| public class ParameterContextResourceTest { |
Contributor
There was a problem hiding this comment.
The public modifier can be removed
| final ParameterDescriptor inheritedDescriptor = new ParameterDescriptor.Builder().name(inheritedParameterName).build(); | ||
| final Parameter inheritedParameter = new Parameter.Builder() | ||
| .descriptor(inheritedDescriptor) | ||
| .value("provider-value") |
Contributor
There was a problem hiding this comment.
It looks like like provider-value should be declared as a variable and reused instead of stated multiple times across different lines in this method
| parameterEntity.getParameter().setInherited(!locallyOwned); | ||
| } else { | ||
| final ParameterContext containingParameterContext = getContainingParameterContext(parameterContext, parameter, locallyOwned); | ||
| final boolean isInherited = !locallyOwned && !Objects.equals(parameterContext.getIdentifier(), containingParameterContext.getIdentifier()); |
Contributor
There was a problem hiding this comment.
If a user has configured an alias using #{Parameter Name} does this approach handle it? It seems like the inheritance check would end up overriding that reference, using the resolved value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-16226 - Parameter Context update fails when adding provider-backed inheritance in a cluster
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000VerifiedstatusPull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation