MINIFICPP-2771 Use separate state managers in schedule and trigger threads#2157
Open
lordgamez wants to merge 2 commits intoapache:mainfrom
Open
MINIFICPP-2771 Use separate state managers in schedule and trigger threads#2157lordgamez wants to merge 2 commits intoapache:mainfrom
lordgamez wants to merge 2 commits intoapache:mainfrom
Conversation
szaszm
reviewed
Apr 10, 2026
Comment on lines
52
to
53
| explicit ListingStateManager(gsl::not_null<core::StateManager*> state_manager) | ||
| : state_manager_(state_manager) { |
Member
There was a problem hiding this comment.
In parameters, I'd use references instead of not_null pointers, but in data members, I'd keep the not_null pointer, because members generally shouldn't be const.
Suggested change
| explicit ListingStateManager(gsl::not_null<core::StateManager*> state_manager) | |
| : state_manager_(state_manager) { | |
| explicit ListingStateManager(core::StateManager& state_manager) | |
| : state_manager_(&state_manager) { |
Comment on lines
+27
to
+28
| if (!state_manager_) { | ||
| return; |
Member
There was a problem hiding this comment.
Shouldn't this be an error, like an exception?
Contributor
Author
There was a problem hiding this comment.
Good point, I updated state_manager_ to be not null so this check is not needed in 3a47d1b
extensions/aws/s3/S3Wrapper.cpp
Outdated
Comment on lines
472
to
473
| void S3Wrapper::initializeMultipartUploadStateStorage(gsl::not_null<core::StateManager*> state_manager) { | ||
| multipart_upload_storage_ = std::make_unique<MultipartUploadStateStorage>(state_manager); |
Member
There was a problem hiding this comment.
Suggested change
| void S3Wrapper::initializeMultipartUploadStateStorage(gsl::not_null<core::StateManager*> state_manager) { | |
| multipart_upload_storage_ = std::make_unique<MultipartUploadStateStorage>(state_manager); | |
| void S3Wrapper::initializeMultipartUploadStateStorage(core::StateManager& state_manager) { | |
| multipart_upload_storage_ = std::make_unique<MultipartUploadStateStorage>(state_manager); |
lordgamez
force-pushed
the
MINIFICPP-2771
branch
from
3a197b2 to
305a31f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/MINIFICPP-2771
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.