Run lib.profiler unit tests in CI#9526
Open
wilx wants to merge 2 commits into
Open
Conversation
wilx
marked this pull request as ready for review
July 19, 2026 21:17
Assisted-by: OpenAI GPT-5 Codex
Assisted-by: OpenAI GPT-5 Codex
wilx
force-pushed
the
ci-lib-profiler-tests
branch
from
July 19, 2026 21:31
997f715 to
d9a1a8f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows up on the review discussion in #9497 by adding the
profiler/lib.profilerunit tests to the main CI workflow.The new CI step runs the existing
test-unittarget while disabling compilation of the legacy QA-functional source set, which is not executed by that target.The legacy CPU snapshot tests now use deterministic
SampledThreadInfofixtures for the builder logic. A focused test still exercises the publicThreadInfo[]adapter with data fromThreadMXBean, without relying on private JDK constructors, fields, or internalsun.managementclasses.The heap-dump golden output is made deterministic by sorting system-property names and escaping embedded line breaks. The golden file is refreshed for that stable representation and the current JVM's floating-point string representation.
Validation:
69 tests passed with no failures or errors.
Assisted-by: OpenAI GPT-5 Codex
^Add meaningful description above
Click to collapse/expand PR instructions
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
LLMs, Commit messages and PR description:
git log) that all commits have a valid name and email address for you in the Author field.Assisted-by: MODEL_NAME MODEL_VERSIONline appended to the commit message.Assisted-byline from above)If you're a first time contributor, see the Contributing guidelines for more information.
If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.
PR approval and merge checklist:
If this PR targets the delivery branch: don't merge. (full wiki article)