Reduce log level for PersistenceManager deserialization problems to INFO#9525
Reduce log level for PersistenceManager deserialization problems to INFO#9525matthiasblaesing wants to merge 1 commit into
Conversation
As part of 892e14c the default detail level of the logging of PersistenceManager problems was reduced and is only retained if FINE lgging is enabled. On the other hand the log level for the shorted message was raised to WARNING from INFO. This causes the problem to become visible to the end user. Logs with level WARNING and an attached exception cause a visible notification via the chain: NbErrorManager -> NotifyExcPanel#notify -> NotifyExcPanel#shallNotify This in turn even shows the detailed message because the content of the serialization problem is attached to the exception via Exceptions.attachLocalizedMessage in XMLSettingsSupport. Closes: apache#9524
mbien
left a comment
There was a problem hiding this comment.
didn't know that warning level can open dialogs in some cases
The usual situation when this code path ran was when an opened project was moved while NB was closed, next launch would dump everything into the log. This happened often to me while testing, but I never saw a dialog.
neilcsmith-net
left a comment
There was a problem hiding this comment.
Thanks for this. Have noticed more in platform development than the IDE recently.
This happened often to me while testing, but I never saw a dialog.
@mbien am curious if that was always with tryme? Can't find anything obvious, but potentially different logging under that scenario.
@neilcsmith-net I started the release version of NB 28, created a project and closed NB. Deleted the project folder, started NB -> check log and you shall see a xml dump with serialized data. In NB 29+ this should be fixed and a simple warning log line should appear, mentioning the file. That warning is now an INFO line after this PR it seems. My guess is that a different exception is caught (completely different scenario to the one described above) which has some kind of exception attachment which causes the warning line to be displayed in UI - which is unfortunate. I didn't know that this automation existed. |
As part of 892e14c the default detail level of the logging of PersistenceManager problems was reduced and is only retained if FINE lgging is enabled. On the other hand the log level for the shorted message was raised to WARNING from INFO.
This causes the problem to become visible to the end user. Logs with level WARNING and an attached exception cause a visible notification via the chain:
NbErrorManager->NotifyExcPanel#notify->NotifyExcPanel#shallNotifyThis in turn even shows the detailed message because the content of the serialization problem is attached to the exception via
Exceptions.attachLocalizedMessagein
XMLSettingsSupport.Closes: #9524