Skip to content

Reduce log level for PersistenceManager deserialization problems to INFO#9525

Open
matthiasblaesing wants to merge 1 commit into
apache:deliveryfrom
matthiasblaesing:persistence_manager
Open

Reduce log level for PersistenceManager deserialization problems to INFO#9525
matthiasblaesing wants to merge 1 commit into
apache:deliveryfrom
matthiasblaesing:persistence_manager

Conversation

@matthiasblaesing

Copy link
Copy Markdown
Contributor

As part of 892e14c the default detail level of the logging of PersistenceManager problems was reduced and is only retained if FINE lgging is enabled. On the other hand the log level for the shorted message was raised to WARNING from INFO.

This causes the problem to become visible to the end user. Logs with level WARNING and an attached exception cause a visible notification via the chain:

NbErrorManager -> NotifyExcPanel#notify -> NotifyExcPanel#shallNotify

This in turn even shows the detailed message because the content of the serialization problem is attached to the exception via

Exceptions.attachLocalizedMessage

in XMLSettingsSupport.

Closes: #9524

As part of 892e14c the default detail
level of the logging of PersistenceManager problems was reduced and is
only retained if FINE lgging is enabled. On the other hand the log
level for the shorted message was raised to WARNING from INFO.

This causes the problem to become visible to the end user. Logs with
level WARNING and an attached exception cause a visible notification
via the chain:

NbErrorManager -> NotifyExcPanel#notify -> NotifyExcPanel#shallNotify

This in turn even shows the detailed message because the content of the
serialization problem is attached to the exception via

Exceptions.attachLocalizedMessage

in XMLSettingsSupport.

Closes: apache#9524
@matthiasblaesing matthiasblaesing added this to the NB31 milestone Jul 18, 2026
@matthiasblaesing matthiasblaesing added Platform [ci] enable platform tests (platform/*) ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labels Jul 18, 2026
@matthiasblaesing
matthiasblaesing requested a review from mbien July 19, 2026 09:10
@mbien mbien linked an issue Jul 19, 2026 that may be closed by this pull request

@mbien mbien left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't know that warning level can open dialogs in some cases

The usual situation when this code path ran was when an opened project was moved while NB was closed, next launch would dump everything into the log. This happened often to me while testing, but I never saw a dialog.

@neilcsmith-net neilcsmith-net left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. Have noticed more in platform development than the IDE recently.

This happened often to me while testing, but I never saw a dialog.

@mbien am curious if that was always with tryme? Can't find anything obvious, but potentially different logging under that scenario.

@mbien

mbien commented Jul 20, 2026

Copy link
Copy Markdown
Member

@mbien am curious if that was always with tryme? Can't find anything obvious, but potentially different logging under that scenario.

@neilcsmith-net I started the release version of NB 28, created a project and closed NB. Deleted the project folder, started NB -> check log and you shall see a xml dump with serialized data. In NB 29+ this should be fixed and a simple warning log line should appear, mentioning the file.

That warning is now an INFO line after this PR it seems. My guess is that a different exception is caught (completely different scenario to the one described above) which has some kind of exception attachment which causes the warning line to be displayed in UI - which is unfortunate. I didn't know that this automation existed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) Platform [ci] enable platform tests (platform/*)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NB30 hangs on startup when modal popup are shown

3 participants