Facelift on spellchecker module#9515
Open
lkishalmi wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Well this is one of the old code we have. Before adding HunSpell support a little facelift won't hurt.
The
SpellcheckerOptionsPanelcould see an iteration or two. The+/-prefixes in the strings in CheckboxList model bothers me. Though I wanted to avoid accidental functionality changes.The
ErrorHighlightPainterinComponentPeerbecame an instance method and used as a method reference instead of creating one instance for each miss-spelled word.I've removed the
getDictionary()method inDictionaryImplwhich was supposed to lazy initialize thedictionaryfield. Though as it was called multiple times during the construction it seems to be pretty useless.Added a few records where it made sense.