NBM project properties window: evaluate javac.release properties

[mbien]

NBM project properties window now evaluates the javac.release property to get its value.

this should allow something like:

javac.release=${default.javac.release}

in the [module]/nbproject/project.properties file (assuming it can be resolved)

tested:

added default.javac.release=18 to nbbuild/user.build.properties and updated a module like described above. This got picked up by both the build and the project properties window UI.

this might be the easiest way to set a default value for modules. I tried to find a way to allow removal of the property entirely (as signal to use the default), but I couldn't get that to work.

[neilcsmith-net]

I think this makes sense, at least as an immediate fix. Aligns more with changes you made at https://github.com/apache/netbeans/blob/master/apisupport/apisupport.ant/src/org/netbeans/modules/apisupport/project/NbModuleProject.java#L693 Not sure if that could easily be just in one place? The project properties are constructed with a reference to NbModuleProject.

What didn't work trying to set a default? The build, the editor, the UI ?? The default properties fallback seems a bit suspect in all this https://github.com/apache/netbeans/blob/master/apisupport/apisupport.ant/src/org/netbeans/modules/apisupport/project/ui/customizer/SingleModuleProperties.java#L133

[mbien]

The default properties fallback seems a bit suspect in all this

the ant evaluator itself also sets defaults at

netbeans/apisupport/apisupport.ant/src/org/netbeans/modules/apisupport/project/Evaluator.java

Line 400 in ad4ae12

defaults.put(SingleModuleProperties.JAVAC_SOURCE, "1.4"); // NOI18N

if we wanted to set a default for NB, where would we put it? build.properties isn't in the context of the evaluator.
e.g setting a breakpoint at

netbeans/ide/project.ant/src/org/netbeans/spi/project/support/ant/EditableProperties.java

Line 126 in ad4ae12

return delegate.getProperty(key);

and running evaluator.getProperty("bootstrap.jdk.release") returns null.

nbbuild/user.build.properties does work, but is currently not used and on the gh ignore list.

[neilcsmith-net]

I guess perhaps considering putting build.properties in the evaluator context?! Or understanding why it was left out. And also looking at what defaults get set via XML. Having different defaults in 15 different places isn't great! 😄 The UI needs to reflect the build. Which relates back to your earlier issues on #5455

Anyway, that's not one to experiment with in freeze week. This seems a good change for now.

[mbien]

we can move it to NB 31. Since without being able to set the default somehow, this has no real use case.