Bump com.github.siom79.japicmp:japicmp-maven-plugin from 0.25.6 to 0.26.0#1888
Conversation
Bumps [com.github.siom79.japicmp:japicmp-maven-plugin](https://github.com/siom79/japicmp) from 0.25.6 to 0.26.0. - [Release notes](https://github.com/siom79/japicmp/releases) - [Changelog](https://github.com/siom79/japicmp/blob/master/release.py) - [Commits](siom79/japicmp@japicmp-base-0.25.6...japicmp-base-0.26.0) --- updated-dependencies: - dependency-name: com.github.siom79.japicmp:japicmp-maven-plugin dependency-version: 0.26.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
|
|
@siom79 can you shed any light what happens here? |
|
The logs say: Version 0.26.0 did not change anything regarding change detection, only a fix in the markdown report. |
|
And between 0.25.6 and 0.25.7 there was this issue fixed. |
Root CauseThe errors stem from two independent changes that interact with each other: 1. A deliberate API change in The three methods were changed from returning the abstract interface types to returning their
The motivation was explicitly documented in the commit message: "generic scheme creates 2. A bug fix in japicmp 0.25.7 (issue #507, PR #508) Prior to 0.25.7, japicmp incorrectly matched non-bridge methods against compiler-generated Is This a Real Binary Incompatibility?No. Covariant return types are explicitly supported by the Java Language Specification Any code compiled against the old API that calls The only scenario where this change can cause a real (silent) breakage is subclassing: Relationship to japicmpThe detection itself is correct — the API did change in 2023 and japicmp 0.25.6 was A dedicated issue has been filed with the japicmp project to introduce a separate, less Recommended Fix for This ProjectUntil japicmp handles covariant return type changes natively, the appropriate fix on the <excludes>
<exclude>
org.eclipse.aether.util.version.GenericVersionScheme#parseVersion(java.lang.String)
</exclude>
<exclude>
org.eclipse.aether.util.version.GenericVersionScheme#parseVersionRange(java.lang.String)
</exclude>
<exclude>
org.eclipse.aether.util.version.GenericVersionScheme#parseVersionConstraint(java.lang.String)
</exclude>
</excludes> |
|
@siom79 Many thanks! |
|
I propose to postpone japicmp update until siom79/japicmp#522 is fixed. |
|
Just released 0.26.1. That should fix this issue. |
|
Superseded by #1893. |
Bumps com.github.siom79.japicmp:japicmp-maven-plugin from 0.25.6 to 0.26.0.
Release notes
Sourced from com.github.siom79.japicmp:japicmp-maven-plugin's releases.
Commits
aa07518[maven-release-plugin] prepare release japicmp-base-0.26.0c194aeeupgraded version in *.md files to 0.26.08103fe2mvn set version to 0.26.0-SNAPSHOTfc65dbcFix link format in ReleaseNotes.md8a4609eUpdate ReleaseNotes.md for version 0.26.01766fedMerge pull request #518 from siom79/release-v0.25.7915b232Merge pull request #517 from siom79/claude/optional-file-methods-oSmHD1aa1018Fix NPE in MarkdownOutputGenerator for byte-based JApiCmpArchive (issue #516)c01b2c7Merge pull request #515 from siom79/siom79-patch-186d3b50Remove build status badge from READMEDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)