fix(runtime-host): surface session copy failure cause - #4044
Conversation
Preserve rollback semantics while returning a bounded, redacted summary of the commit error and logging the full sanitized diagnostic. Generated-by: OpenAI Codex
|
This is a synthesis of the independent blind review by @Sol-404ARE at exact head What I checked myself:
Findings from Sol's review (file:line anchored): Standards — GO (0 P0–P3)
Spec — GO (0 P0–P3)
What was proven green: What I did not judge: a full coordinator failure-injection E2E with injected Gate: Standards 0 and Spec 0 — code is GO, but the hosted CI gate is pending (
|
Summary
persistence_failed, rollback, and unknown-outcome semantics for conversation-copy commit failures.Fixes #4006
Verification
npm --workspace @maka/runtime-host run typechecknpm --workspace @maka/runtime-host run buildnode --test packages/runtime-host/dist/__tests__/session-revision-diagnostics.test.js(3 passed)npm run format:checknpm run lintnpm run check:asf-headerstest:distwas attempted on Windows, but did not complete: unrelated IPC/filesystem tests reportedEBUSY,EPERM, andread_eof, while two execution-composition workers stopped making progress. The affected suites above passed.AI use
Select exactly one:
Tool(s) and scope: OpenAI Codex implemented the Runtime Host diagnostic formatting, coordinator wiring, regression tests, and drafted this PR at @fxl112233's direction. @fxl112233 is the human contributor of record.
Checklist
Does this PR entail a change in behavior?