test(skills): cover Windows catalog - #3964
Open
orangeCatDeveloper wants to merge 1 commit into
Open
Conversation
orangeCatDeveloper
force-pushed
the
fix/3901-windows-skill-catalog
branch
from
August 27, 2026 03:04
66af60f to
22d5737
Compare
orangeCatDeveloper
force-pushed
the
fix/3901-windows-skill-catalog
branch
2 times, most recently
from
August 27, 2026 03:10
92e741b to
d7ca3a7
Compare
orangeCatDeveloper
force-pushed
the
fix/3901-windows-skill-catalog
branch
from
August 27, 2026 03:12
d7ca3a7 to
215cc71
Compare
orangeCatDeveloper
marked this pull request as ready for review
August 27, 2026 03:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3901
Summary
Windows could report a healthy Skill Catalog suite while six filesystem, recovery, and multi-client contracts never ran.
Five tests returned before their assertions on Windows, while the real two-client transport test carried an explicit Windows skip. The tests now use Windows ACLs for unreadable fixtures, accept the Windows process-termination representation, exercise the existing named-pipe transport with an isolated skill home, and retain the open-handle and symlink recovery assertions.
The blocking Windows recovery lane runs every Skill Catalog test file and requires exactly 90 passes with zero skips; its CI contract prevents the file list or count from silently shrinking.
Verification
Before:
After (Windows recovery run):
AI use
Tool(s) and scope: Codex implemented the cross-platform test fixtures and Windows CI gate, then performed local validation and an independent subagent review.
Checklist
Does this PR entail a change in behavior?