feat(commands): Introduce subcommand as a first-class command abstraction#3558
Open
geetanshjuneja wants to merge 1 commit into
Open
feat(commands): Introduce subcommand as a first-class command abstraction#3558geetanshjuneja wants to merge 1 commit into
geetanshjuneja wants to merge 1 commit into
Conversation
41b025b to
f2168ea
Compare
Member
|
Hello @geetanshjuneja. Thanks for your contribution. If you used an LLM, please follow our guidelines for AI-assisted contributions: https://kvrocks.apache.org/community/contributing#guidelines-for-ai-assisted-contributions |
Author
|
Hi @jihuayu, updated the description. Changes in this PR are exactly same as your PR, once this is merged I can continue refactoring other subcommands. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a subcommand registration framework as well resolution of command to the correct subcommand. This PR contains all the changes of #3413 while addressing some reviewer comments in it.
Following changes are included in this PR:
MakeSubCmdAttr()is used to register subcommand metadata, such as arity, flags, key specs, and category.AI disclosure
Used AI to add namspace subcommand integration tests in
tests/gocase/unit/namespace/namespace_test.go.