KNOX-3424: Dynamic audience handling in the KNOXTOKEN service - #1356
Open
hanicz wants to merge 1 commit into
Open
KNOX-3424: Dynamic audience handling in the KNOXTOKEN service#1356hanicz wants to merge 1 commit into
hanicz wants to merge 1 commit into
Conversation
Test Results 4 files 4 suites 9s ⏱️ Results for commit 8d4092f. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KNOX-3424 - Dynamic audience handling in the KNOXTOKEN service
What changes were proposed in this pull request?
Callers can now request a token's aud claim per request via an audience query parameter, validated against the existing
knox.token.audienceswhitelist to prevent audience/token spoofing.Behavior
audienceparam → unchanged; the statically configuredknox.token.audiencesare used.audienceparam + no whitelist configured →400(secure by default — nothing to validate against).audienceparam + all values in the whitelist → only the requested audience(s) land inaud.audienceparam + any value not whitelisted →400.How was this patch tested?
Unit tests, local tests
Integration Tests
N/A
UI changes
N/A