KNOX-3312 - Client Credentials Flow with HTTP Basic needs Unwrapped S…#1219
Open
lmccay wants to merge 2 commits intoapache:masterfrom
Open
KNOX-3312 - Client Credentials Flow with HTTP Basic needs Unwrapped S…#1219lmccay wants to merge 2 commits intoapache:masterfrom
lmccay wants to merge 2 commits intoapache:masterfrom
Conversation
Test Results21 tests 21 ✅ 1s ⏱️ Results for commit 4183f70. ♻️ This comment has been updated with latest results. |
moresandeep
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KNOX-1234 - Client Credentials Flow with HTTP Basic needs Unwrapped Servlet Request
What changes were proposed in this pull request?
Current implementation can't get to the grant_type request param.
Unit tests mock out the requests and make it hard to tease this out as an issue.
When we know that there is an Authorization header and that it is Basic then we need to check whether there is the hardcoded username of token or passcode and if not, unwrap the request to check for a grant_type for OAuth client_credentials and handle it appropriately.
Current implementation tries to check that but the params are hidden by the wrappers.
How was this patch tested?
All existing unit and integration tests were run.
Manually tested the flow.
Also added a request wrapper to the unit tests of the mock http request.
This ensures that the access to the request params for OAuth flows does not regress.